Skip to content

Fix: Uninstaller for service component not working #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LordHepipud merged 1 commit into from
Mar 16, 2022
Merged

Fix: Uninstaller for service component not working #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/100-General/10-Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Released closed milestones can be found on [GitHub](https://github.com/Icinga/ic
* [#478](https://github.com/Icinga/icinga-powershell-framework/pull/478) Fixes connection option "Connecting from parent system" which is not asking for ca.crt path
* [#479](https://github.com/Icinga/icinga-powershell-framework/pull/479) Fixes possible exceptions while trying to remove downloaded repository temp files which might still contain a file lock from virusscanners or other tasks
* [#480](https://github.com/Icinga/icinga-powershell-framework/pull/480) Fixes service locking during Icinga Agent upgrade and ensures errors on service management are caught and printed with internal error handling
* [#490](https://github.com/Icinga/icinga-powershell-framework/pull/490) Fixes the command `Uninstall-IcingaComponent` for the `service` component which is not doing anything

### Enhancements

Expand Down
4 changes: 2 additions & 2 deletions lib/core/repository/Uninstall-IcingaComponent.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ function Uninstall-IcingaComponent()
}

if ($Name.ToLower() -eq 'agent') {
return Uninstall-IcingaAgent -RemoveDataFolder:$RemovePackageFiles;
return (Uninstall-IcingaAgent -RemoveDataFolder:$RemovePackageFiles);
}

if ($Name.ToLower() -eq 'service') {
return; Uninstall-IcingaForWindowsService -RemoveFiles:$RemovePackageFiles;
return (Uninstall-IcingaForWindowsService -RemoveFiles:$RemovePackageFiles);
}

$ModuleBase = Get-IcingaForWindowsRootPath;
Expand Down