Use a BlockingCollection to avoid busy loop in REST API threads - #497
Merged
Conversation
haxtibal
force-pushed
the
feature/avoid_busy_loop
branch
from
March 18, 2022 17:02
69c05c9 to
380c840
Compare
haxtibal
force-pushed
the
feature/avoid_busy_loop
branch
from
March 29, 2022 21:13
380c840 to
e5f8589
Compare
Collaborator
|
Thank you for the PR! It looks great. Could you please update the PR with a changelog as bugfix for v1.9.0: I will then merge it immediately and publish it with v1.9.0 |
Collaborator
|
One more addition. Could you please replace $RESTThreadQueue = [System.Collections.Concurrent.BlockingCollection[PSObject]]::new(
[System.Collections.Concurrent.ConcurrentQueue[PSObject]]::new()
);with $RESTThreadQueue = New-Object System.Collections.Concurrent.BlockingCollection[PSObject] `
-ArgumentList (New-Object System.Collections.Concurrent.ConcurrentQueue[PSObject]);Otherwise the REST-Api will no longer work in Windows 2012 R2 or older. |
The former implementation had 5 threads permanently spinning fast (10ms sleep) while waiting for a REST connection to process. This causes higher load in general and it breaks systems where "Turn on PowerShell Script Block Logging policy" is enabled, because then each PS statement including Start-Sleep is logged - resulting in 500 event log entries per second. It's a suggested setting in some hardening guidelines. We can easily replace the Queue with a BlockingCollection backed by a ConcurrentQueue, which has the built-in feature to sleep until there are new items. Now the REST API threads consumes zero CPU time while waiting.
haxtibal
force-pushed
the
feature/avoid_busy_loop
branch
from
March 30, 2022 09:15
e5f8589 to
d215cfd
Compare
Contributor
Author
|
Thanks, just applied your suggestions. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The former implementation had 5 threads permanently spinning fast (10ms sleep) while waiting for a REST connection to process. This causes higher load in general and it breaks systems where Turn on PowerShell Script Block Logging policy is enabled, because then each PS statement including
Start-Sleepis logged - resulting in 500 event log entries per second. It's a suggested setting in some hardening guidelines.We can easily replace the Queue with a BlockingCollection backed by a ConcurrentQueue, which has the built-in feature to sleep until there are new items. Now the REST API threads consumes zero CPU time while waiting.