Improve NPV summation accuracy and validate discount rates - #11
Merged
Conversation
dylanjm
approved these changes
Jul 22, 2026
dylanjm
left a comment
Collaborator
There was a problem hiding this comment.
Changes are good, documentation is updated, and will catch edge cases with discount rates. Approved to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
math.fsumindcaf.metrics.npv()to preserve small residuals when large offsetting cashflows cause cancellation.-1, and document the shared contract forCashFlowStream.npv()andGenerationStream.discounted_sum().Validation lives in the shared NPV primitive so every consumer enforces the same real-valued rate domain.
math.fsumimproves reduction accuracy without introducing decimal arithmetic or removing support for finite rates above-1.Closes #4
Closes #8