Fix scalar generation revenue escalation - #25
Merged
Conversation
caleb-sitton-inl
left a comment
Collaborator
There was a problem hiding this comment.
The implementation and test updates look good. I do wonder if explicitly not escalating prices from price policies reduces their utility, especially for the fixed option. Would it be helpful to provide apply_escalation arguments for price policy construction methods so the user doesn't always have to do it manually when they need to use a GenerationPrice?
Collaborator
Author
|
That's a good point. I think it would be a good item for future improvement to DCAF. I've opened #26 to track this as a potential development item we can tackle later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnergyProject.generation_revenue(price=...), including earliest-generation reference-date fallback when no explicit reference date is configured.price_policy=for completeGenerationPricepolicies so fixed, scheduled, callable, contract, and remainder prices remain explicit and are not escalated twice.The implementation preserves the distinction between the scalar convenience API and complete
GenerationPricepolicies inRevenueConfigandProjectCompiler, allowing only the former to inheritdefault_escalation. Outage fallback reuses the compiler’s resolved scalar policy so revenue and lost-revenue calculations stay consistent without duplicating escalation logic.Closes #24