Repository navigation
Skip icon CSS generation without global theming - #26
Conversation
Fixes a null pointer dereference when global theme application is disabled.
|
Good catch, thanks! However, the fix as it is now is problematic. Breeze icons still need to be re-colored, even if other toolkit theming is disabled. Dark mode is still applied to some supporting styles (e.g. Fusion), and in such cases not re-coloring symbolic icons will lead to dark-on-dark icons. If we don't have our palette created, the CSS can be generated from the effective application palette, which will take the active style's standard palette into consideration. But it is calculated only after the platform theme finishes its turn, so just using it in Would you be OK with expanding the patch to that degree, or would you prefer me to do that? |
|
I prefer to you to do that. I'm not confident in expanding the patch with additional requirement to recolorize with application color theme when the cosmic global theme application is disabled, myself. |
|
No worries. Still, thanks a lot for spotting and identifying the issue! |
Fixes a null pointer dereference when global theme application is disabled.
Without this guard, Qt applications loading the CuteCosmic platform theme segfault during startup when global theme application is disabled.