feat(*): removing theming widget#304
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the docs-template “theming widget” feature end-to-end (build-time env resolution, virtual module exports, and the Astro component), and updates dependent docs/config to no longer reference or configure it.
Changes:
- Removed theming widget build-time plumbing (
themeApiUrl/ widget script) fromsrc/integration.tsandsrc/virtual-modules.d.ts. - Deleted
src/components/ThemingWidget.astroand removed its package export. - Removed theming-widget config keys from Angular docs
environment.jsonfiles; updated Angular MDX topics to drop the theming-widget GIF; bumpedigniteui-astro-componentsto0.0.22.
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/virtual-modules.d.ts | Drops theming-widget-related exports from the virtual:docs-template/nav-html module typing. |
| src/integration.ts | Removes theming env resolution and stops emitting theming-widget virtual exports. |
| src/components/ThemingWidget.astro | Deletes the theming widget component implementation. |
| package.json | Removes export for ThemingWidget.astro; bumps igniteui-astro-components to 0.0.22. |
| package-lock.json | Locks igniteui-astro-components to 0.0.22. |
| docs/xplat/package.json | Bumps igniteui-astro-components to 0.0.22. |
| docs/angular/package.json | Bumps igniteui-astro-components to 0.0.22. |
| docs/angular/src/content/kr/environment.json | Removes theming widget configuration keys. |
| docs/angular/src/content/jp/environment.json | Removes theming widget configuration keys. |
| docs/angular/src/content/en/environment.json | Removes theming widget configuration keys. |
| docs/angular/src/content/jp/components/general/angular-grid-overview-guide.mdx | Removes theming-widget GIF import/usage (but still contains theming-widget text that should be updated). |
| docs/angular/src/content/en/components/general/angular-grid-overview-guide.mdx | Removes theming-widget GIF import/usage (but still contains theming-widget text that should be updated). |
| cspell.json | Removes themingwidget from the custom dictionary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theming widget is currently not shown but also breaks AbortController event handling so we are removing it until a better theming solution is introduced to work for all platforms.