fix(bem): resolve adjacent-compounds deprecation warnings#582
Merged
Conversation
…e selector contexts
simeonoff
added
❌ status: awaiting-test
adrianptrv
approved these changes
Jun 11, 2026
adrianptrv
added
✅ status: verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #581
The bem-elem mixin was generating invalid adjacent compound selectors (e.g. [aria-selected=false]__content-wrapper) when called inside an attribute selector block.
Root cause: bem--extract-block and the $nested flag had no awareness of [...] attribute selectors — both treated them as plain block context, causing the element separator __ to be appended directly onto the attribute selector.
Changes:
bem--contains-attr()— detects[in a selector stringbem--extract-block— strips[...](and any preceding descendant-combinator space) to return the bare block namebem--extract-first-selector— treats a space before[as a descendant combinator, keeping the full selector intact as$first$nestedinbem-elem— attribute selector contexts are now correctly treated as nested, producingblock[attr] block__elem(compound) andblock [attr] block__elem(descendant)The easiest way to test the fixes in this PR is to install the package in the scoped-styles branch in Ignite UI for Angular.