Yaoning3 onboarding#85
Open
quyaoning wants to merge 3 commits into
Open
Conversation
johnathanvogt
left a comment
johnathanvogt
left a comment
There was a problem hiding this comment.
Firmware and LED board look good
You have some schematic changes for the horns board that have to do with the positing of your horns modules and diode, hard to explain here
If youre curious, feel free to ask but for now youre all set to join elec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All required onboarding projects are completed.
Report: https://github.com/IlliniSolarCar/ElecOnboarding25/blob/yaoning3_onboarding/Hardware%2Fhorn%2FI8QuotationReport_syvaa7kn.pdf
It didn't pass the nearest copper to edge check as it very strangely marked a point of edge cutting line as a copper component and claimed it 0mm distance to edge. I tried redrawing the edge but it didn't work.