fix: preserve smoothing_factor across jpeg_set_defaults calls #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`set_scan_optimization_mode()` and `set_fastest_defaults()` call `jpeg_set_defaults()` which resets all compression parameters, including `smoothing_factor`. This caused `set_smoothing_factor()` to have no effect if called before these methods. Fix by saving and restoring `smoothing_factor` around the `jpeg_set_defaults()` calls. Fixes ImageOptim#45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
set_scan_optimization_mode()andset_fastest_defaults()calljpeg_set_defaults()which resets all compression parameters, includingsmoothing_factor. This causedset_smoothing_factor()to have no effect if called before these methods.Fix
Save and restore
smoothing_factoraround thejpeg_set_defaults()calls.Test
Added regression test that verifies:
set_smoothing_factor()works regardless of whether it's called before or afterset_scan_optimization_mode()Fixes #45