Correct quality precedence and cache-hit header consistency by Joker666 · Pull Request #70 · ImgForger/imgforge

Joker666 · 2026-08-16T17:32:45Z

Stack (merge bottom-up)

Restructure processing and service, and close the geometry compatibility gaps #66 Restructure processing and service, and close the geometry compatibility gaps

Process animated sources frame by frame #67 Process animated sources frame by frame

Add the imgproxy delivery layer #68 Add the imgproxy delivery layer

Build the image on Debian trixie for libvips 8.16 #69 Build the image on Debian trixie for libvips 8.16

Correct quality precedence and cache-hit header consistency #70 Correct quality precedence and cache-hit header consistency

Bring the remaining docs up to date #71 Bring the remaining docs up to date

Let width and height fill in a resize the type created #72 Let width and height fill in a resize the type created

Close the roadmap's remaining known gaps #73 Close the roadmap's remaining known gaps

Implement the Pro options that were only ever cheap #74 Implement the Pro options that were only ever cheap

Run the pipeline in imgproxy's stage order #75 Run the pipeline in imgproxy's stage order

Each PR targets the one before it, so its diff shows only its own change. Together they make up the 0.18.0 release.

Stacked on #69. Three things a review pass turned up.

A configured IMGFORGE_QUALITY was seeding the URL's own quality field, which made it outrank a format_quality the URL had asked for. The configured value is now kept separately and consulted last, matching imgproxy: URL quality, then URL format_quality, then configuration, then the built-in default.

The source URL is now resolved before the cache lookup rather than after. A source removed from IMGFORGE_ALLOWED_SOURCES was still being served out of the cache, and the canonical header appeared on a miss but not on a hit.

preserve_hdr named the gainmap keep flag unconditionally. That flag only exists from libvips 8.16, and naming it on an older build makes the option-string parser reject the whole encode — so a deployment linked against an older system libvips failed every request that set the option instead of merely losing the gain map. The version is now checked once at startup.

Validation

cargo fmt -- --check
cargo clippy --all-targets -- -D warnings
cargo test --all -- --test-threads=1

Plus a real image build, and a container serving every output format, Accept negotiation, the caching headers, and an animated GIF resize.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be75795210

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-16T17:35:05Z

+        self.quality
+            .or_else(|| self.save.format_quality.get(format).copied())
+            .or(self.default_quality)


Invalidate cache entries after changing quality precedence

When upgrading an installation that uses the recoverable disk or hybrid cache, a request containing format_quality that was previously encoded under IMGFORGE_QUALITY keeps the same processed_cache_key, so process_path returns the old bytes before this new precedence is evaluated. Such URLs therefore continue receiving the incorrectly configured quality until eviction or manual cache deletion; include a cache namespace/version that distinguishes outputs produced with the corrected precedence.

Useful? React with 👍 / 👎.

Joker666 · 2026-08-17T01:19:07Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bcfb7a10c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-17T01:21:55Z

+        let cached_source = SourceMetadata {
+            url: Some(decoded_url.clone()),
+            ..SourceMetadata::default()


Key cached provenance by the resolved source URL

When a disk or hybrid cache survives a restart that changes IMGFORGE_BASE_URL, a relative source path resolves to a new URL but processed_cache_key still depends only on the request path. A cache hit can therefore return bytes fetched from the old base URL while this newly constructed metadata emits a canonical Link for the new URL. Include the resolved source in the cache identity or persist the original source URL with the cached value so the header cannot misidentify cached content.

Useful? React with 👍 / 👎.

Joker666 · 2026-08-17T05:23:07Z

@codex review

chatgpt-codex-connector · 2026-08-17T05:25:23Z

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 53a3ec956a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Joker666 · 2026-08-21T05:44:13Z

@codex review

chatgpt-codex-connector · 2026-08-21T05:46:43Z

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 9bc3f76fbc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Joker666 · 2026-08-21T06:36:03Z

@codex review

chatgpt-codex-connector · 2026-08-21T06:38:38Z

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: c68658de0d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Joker666 · 2026-08-21T19:33:37Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e7bf091a1a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-21T19:36:09Z

+    // build makes the option-string parser reject the whole encode, so a
+    // deployment linked against an older system libvips would fail every
+    // request that set preserve_hdr rather than merely losing the gain map.
+    if options.preserve_hdr.unwrap_or(false) && supports_gainmap_flag() {


Document the old-libvips HDR fallback

When running against libvips older than 8.16, this now returns successfully while omitting the gain map, but doc/5_processing_options.md:251 still tells users that enabling preserve_hdr makes encoding fail, and ROADMAP.md:24-27 still lists this runtime check as unimplemented. Update those documents so operators do not mistake a successful response for one that retained all requested HDR data.

Useful? React with 👍 / 👎.

Three things a review pass turned up. A configured IMGFORGE_QUALITY was seeding the URL's own quality field, which made it outrank a format_quality the URL had asked for. The configured value is now kept separately and consulted last, matching imgproxy: URL quality, then URL format_quality, then configuration, then the built-in default. The source URL is now resolved before the cache lookup rather than after. A source removed from IMGFORGE_ALLOWED_SOURCES was still being served out of the cache, and the canonical header appeared on a miss but not on a hit. preserve_hdr named the gainmap keep flag unconditionally. That flag only exists from libvips 8.16, and naming it on an older build makes the option-string parser reject the whole encode — so a deployment linked against an older system libvips failed every request that set the option instead of merely losing the gain map.

chatgpt-codex-connector Bot reviewed Aug 16, 2026

View reviewed changes

Joker666 mentioned this pull request Aug 16, 2026

Run the pipeline in imgproxy's stage order #75

Open

Joker666 force-pushed the fix/quality-precedence branch from be75795 to bcfb7a1 Compare August 17, 2026 00:17

chatgpt-codex-connector Bot reviewed Aug 17, 2026

View reviewed changes

Joker666 force-pushed the fix/quality-precedence branch from bcfb7a1 to 53a3ec9 Compare August 17, 2026 05:05

Joker666 force-pushed the fix/quality-precedence branch from 53a3ec9 to 9bc3f76 Compare August 21, 2026 03:53

Joker666 force-pushed the fix/quality-precedence branch from 9bc3f76 to c68658d Compare August 21, 2026 06:26

Joker666 force-pushed the fix/quality-precedence branch from c68658d to e7bf091 Compare August 21, 2026 19:03

chatgpt-codex-connector Bot reviewed Aug 21, 2026

View reviewed changes

Joker666 force-pushed the fix/quality-precedence branch from e7bf091 to 49d0c29 Compare August 21, 2026 21:13

Joker666 force-pushed the fix/quality-precedence branch from 49d0c29 to 013146c Compare August 21, 2026 21:44

Joker666 force-pushed the fix/quality-precedence branch from 013146c to 9fde2a0 Compare August 21, 2026 23:44

Joker666 force-pushed the fix/quality-precedence branch from 9fde2a0 to aa7a157 Compare August 21, 2026 23:53

Joker666 force-pushed the fix/quality-precedence branch from aa7a157 to e341964 Compare August 21, 2026 23:59

Joker666 force-pushed the fix/quality-precedence branch from e341964 to 4d1339d Compare August 22, 2026 00:19

Joker666 force-pushed the fix/quality-precedence branch from 4d1339d to 4cbc8ef Compare August 22, 2026 00:26

Joker666 force-pushed the fix/quality-precedence branch 2 times, most recently from 59dcfdb to 4a4a7ce Compare August 22, 2026 00:43

Joker666 force-pushed the fix/quality-precedence branch from 4a4a7ce to c811234 Compare August 22, 2026 00:52

Joker666 force-pushed the fix/quality-precedence branch 2 times, most recently from 888c597 to 71708e6 Compare August 22, 2026 01:12

Joker666 force-pushed the fix/quality-precedence branch from 71708e6 to a374194 Compare August 22, 2026 01:23

Uh oh!

Conversation

Joker666 commented Aug 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Validation

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 16, 2026

Choose a reason for hiding this comment

Uh oh!

Joker666 commented Aug 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

Joker666 commented Aug 17, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 17, 2026

Uh oh!

Joker666 commented Aug 21, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 21, 2026

Uh oh!

Joker666 commented Aug 21, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 21, 2026

Uh oh!

Joker666 commented Aug 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Joker666 commented Aug 16, 2026 •

edited

Loading