Add DocC and docs tooling support#4
Conversation
Co-authored-by: Codex
Expand IDE-native package documentation with a SimpleChart DocC catalog, editor support guidance, and richer Quick Help on the zoom/navigation surface. Verification: swift build; swift test; xcodebuild docbuild -scheme SimpleChart -destination 'platform=macOS' -derivedDataPath .build/DerivedData CODE_SIGNING_ALLOWED=NO Committed by Codex.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01fad0e330
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Skip the Chart3D-only wrapper layer when the compiler is older than the toolchain that ships those APIs, so GitHub Actions docbuild on Xcode 16.4 can compile the package. Verification: swift build; swift test; xcodebuild docbuild -scheme SimpleChart -destination 'platform=macOS' -derivedDataPath .build/DerivedData CODE_SIGNING_ALLOWED=NO Committed by Codex.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 228884e1ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
commited by Codex
commited by Codex
commited by Codex
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6432d7d28c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| allowsSelection: Bool = true, | ||
| allowsScrolling: Bool = true | ||
| allowsScrolling: Bool = true, | ||
| allowsZooming: Bool = true |
There was a problem hiding this comment.
SCChartGestureConfiguration previously had only allowsSelection and allowsScrolling, so existing call sites like SCChartGestureConfiguration(allowsSelection: true, allowsScrolling: false) now compile but silently set allowsZooming to true because of this default. That changes runtime behavior for pre-existing code by enabling pinch handling where zoom was never requested, and it conflicts with the new decoder logic that explicitly infers missing allowsZooming from allowsScrolling for backward compatibility. Consider making the source-level default follow allowsScrolling (or adding a compatibility overload) to avoid this regression.
Useful? React with 👍 / 👎.
1 participant
Summary
SimpleChart.docccatalog and an editor support guide for Xcode/sourcekit-lsp usersVerification
swift buildswift testxcodebuild docbuild -scheme SimpleChart -destination 'platform=macOS' -derivedDataPath .build/DerivedData CODE_SIGNING_ALLOWED=NOPull request created by Codex.