feat(home): render warning values as legible chips on filled surfaces - #117
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Home's selected-row fold and the worktree detail's identity zone paint a solid accent fill behind every fact. Warning values — the managed writer's live/uncertain liveness, an unknown dirt or changes observation, and an unavailable PR — kept their yellow ink on that fill, where yellow-on-accent measures about 1.26:1 in the dark palette and 1.21:1 in the light palette. The warning was signalled at the cost of the text being effectively unreadable: an operator could see that something needed attention but could not read what it said.
What
Ship the attached OpenSpec change
accent-fill-warning-chips.warning/warningInk) to the dark, light, and neutral palettes, rather than reusingyellow, which is tuned as ink on a light canvas and too dark to serve as a fill there. The chip clears WCAG AA (≥ 4.5:1) against its ink in every palette and stays separable from the accent it rides.filledLinesnow preserves a chunk's own background the wayhighlightedalready does, via the sharedwithFillhelper.Impact
src/tui-theme.ts— warning-chip fill/ink pair added to all three palettes.src/home-tui.ts— warning values render as chips in the selected-row fold (inlineDetailLines) and the detail zone (detailLines);filledLinespreserves existing backgrounds.test/home-tui.test.ts— chip contract replaces the "stays yellow on the accent fill" expectation; covers filled-chip vs plain-yellow-ink contexts across palettes.test/tui-theme.test.ts— WCAG contrast coverage for the warning-chip pair per palette.How tested
bun run typecheck— clean.bun test— 3268 pass / 0 fail.home-launcherupdated in the archived change and synced to main specs.