Repository navigation
fix(ci): register h3 routes before spawning; retry container first contact - #116
Merged
Merged
Conversation
…ntact serve_h3 registers its route when called (#115), but callers still called it inside a spawned task, so a client could connect before the route existed: - HostHttp3 (ServerHandle) registers the h3 route at bind, before start returns - WebTransport fixtures (rpc transport_webtransport, browser, spans; axum webtransport unit tests) and the Relay node call serve_h3 before spawning - http3 tests spawn the serve_h3 future directly; the #114 retry loop goes, and serve_h3_on_an_endpoint_of_your_own no longer races its double registration Main run 39548930285 failed h3_client_ip_from_quic_peer and call_streams_are_bounded_by_the_call_cap with "timed out". Mailpit and Keycloak: Docker's port proxy accepts before the service listens (Mailpit logs ready before SMTP binds), seen as "incomplete response" and an empty discovery reply; retry the first contact for a bounded time. Signed-off-by: Tom Wieland <tom.wieland@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
- Coverage 97.87% 97.86% -0.01%
==========================================
Files 552 552
Lines 117982 117984 +2
==========================================
- Hits 115470 115469 -1
- Misses 2512 2515 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Industrial
added a commit
that referenced
this pull request
Oct 25, 2026
…ostHttp3 does (#116) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Tom Wieland <tom.wieland@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failures in main run 39548930285 (after #115):
h3_client_ip_from_quic_peer,call_streams_are_bounded_by_the_call_cap): fix(ci): eager h3 route registration; distinct Pebble ports #115 madeserve_h3register its route eagerly, but callers still invoked it insidetokio::spawn(async move { … }). NowHostHttp3registers the route at bind (soServerHandle::startreturns with HTTP/3 ready), and the WebTransport fixtures, the http3 tests and the Relay node callserve_h3before spawning. The test(axum): serve_h3 test waits for the h3 route (last red job on main) #114 reconnect loop is removed.Local: fmt, clippy -D warnings (axum, rpc, relay, mail, test); http3 13/13, axum webtransport 9/9, rpc transport_webtransport + spans 14/14, mailpit 1/1 and keycloak 1/1 (Docker).
🤖 Generated with Claude Code