Repository navigation
Mark source-built plugins with an explicit 0.0.0+source version - #525
Conversation
zengchuang-hw
left a comment
There was a problem hiding this comment.
PASS
首轮独立检视 c573f40a43ceef23ef08507fca662c95ffb65390 → 8b32dae75c0b3b12f3b0426a204e6ad3110ee378,对照 #511 版本契约。逐项比对三个模板,除 version 改为 0.0.0+source 外其余字段一致。现有 builder 把该标记传给 plugin_version,launcher 从 manifest 读取;runtime_version 仍独立报告打包的运行时。Codex/WorkSwarm 显式 release 保持三段数字和运行时版本匹配检查,DSH 仍是 source-only。
新增用例覆盖三个宿主的有/无生成版本源码包,以及两条 release 路径的匹配和失配无产物。批准前必做:无。已静态阅读九个文件及 builder/launcher;未执行构建、测试、release ZIP 校验或原生宿主导入与显示,未把这些限制算作通过。
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base c573f40a43ceef23ef08507fca662c95ffb65390 and head 8b32dae75c0b3b12f3b0426a204e6ad3110ee378.
Verified:
- Three plugin templates stamp
0.0.0+source;plugin_versionfollows the marker whileruntime_versionstill reports the bundled runtime on source builds; release--release-versionpath unchanged per scope (#511 option 2). - Local
tests/test_plugin_source_version.py: 15 passed. - Ready green on tip: full-check 3.10/3.11, declarations, lint-and-smoke (44539700327).
Eligibility: technical/third-party verify only (cursor[bot] collaborator permission none). Not a write+ eligible Approver under docs/agent-collaboration.md; not dual-tip / merge-ready. Merge left to Dong always-on / write+ humans (zengchuang-hw tip Approve already on this head; Dong1017 is author so steward stays off the vote).
a059547
|
Conflicts with |
|
@zengchuang-hw @cursor — merge conflicts with |
zengchuang-hw
left a comment
There was a problem hiding this comment.
PASS
增量 8b32dae7 → a0595474,上轮检视。本轮合入 main 的 Apps workflow 迁移;逐一对比本 PR 九个文件,除 CHANGELOG 带入主线条目外其余八个原文一致。三个模板的 0.0.0+source、独立 runtime version 和 release 校验契约未变。
批准前无必修项。仅静态核对增量、文件和回归定义;未执行构建、测试、宿主安装或查询 CI。
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base 493416520f537590eb8f2a4e74f276f82e488307 and head a05954746606e1ba5cb93794d05074ca21b91bf6.
Independent third-party re-verify after conflict resolution with main (CHANGELOG both-entries merge). Author is Dong1017 → first formal cursor vote on this tip (prior cursor Approve on 8b32dae7… was dismissed by the tip move).
Verified:
- Source-built Codex/WorkSwarm/DSH plugins report
0.0.0+sourcein template/manifest/--plugin-info;runtime_versionremains the bundled runtime; release/--release-versionpath unchanged per docs + CHANGELOG. - Local:
tests/test_plugin_source_version.py→ 15 passed. - Ready CI green on tip: lint-and-smoke, declarations, installed-package 3.10/3.11, full-check 3.10/3.11, dashboard-browser, pr-references (host-compatibility advisory non-blocking).
Eligibility: cursor[bot] collaborator permission is none. This Approve is technical/third-party verify only — not a write+ eligible Approver under docs/agent-collaboration.md, and not a claim that dual tip / merge-ready is satisfied. Merge still needs a write+ independent Approve and steward integration.
Plugins built from a source checkout without --release-version reported the template's hard-coded version: 0.1.0 for the Codex and WorkSwarm plugins and 0.0.0 for DSH. 0.1.0 reads like a real earlier release, and runtime/manifest.json copied the same value into plugin_version. Set the three template versions (plugins/inferrsi/plugin.json, plugins/workswarm/inferrsi/manifest.json and plugins/inferrsi-dsh/package.json) to 0.0.0+source. This is valid SemVer 2.0, and the +source build metadata marks the package as not a release. plugin_version in runtime/manifest.json and in --plugin-info follows it. runtime_version keeps reporting the bundled runtime, so in a source build the two fields differ on purpose. Release builds are unchanged. --release-version still accepts only MAJOR.MINOR.PATCH, must match the built runtime and is rejected before any output is written. DSH has no release mode and carries the marker. Add tests/test_plugin_source_version.py. For Codex, WorkSwarm and DSH it builds from a copied checkout with and without a generated _version.py and checks the top-level metadata, runtime/manifest.json and --plugin-info. For Codex and WorkSwarm it also checks a matching --release-version and a mismatched one. Document the marker in the plugin docs and the release notes, and add a changelog entry. Agent-assisted-by: Claude Code / claude-opus-5-5 [effort=xhigh] (author) Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com> Agent-assisted-by: Codex (conflict resolution)
1600322
a059547 to
1600322
Compare
zengchuang-hw
left a comment
There was a problem hiding this comment.
PASS
增量 a0595474 → 1600322a,上轮检视。已按各自 base 比对有效变更:本轮重基带入现有说明和本地化,三个 source 模板的 0.0.0+source、独立 runtime version、显式 release 校验及 DSH source-only 约束未变。构建器、launcher 与回归测试不受本轮重基影响。无批准前必修项。
仅静态核对固定源码和文件树;未运行构建、测试、宿主安装或查询 CI。
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base 4eaf7fb9f1033a355231002f5bfe353455d66b8d and head 1600322a7bd14060139872b5382e1418a2f9f6c0.
Independent third-party tip re-verify after #516 rebase (prior Approves on a0595474… dismissed). Author is Dong1017 → Dong ineligible; cursor supplies first formal tip vote this round.
Verified:
- Three plugin templates stamp
0.0.0+source(Codexplugin.json, WorkSwarmmanifest.json, DSHpackage.json). - Docs (
codex-plugin.md,workswarm-plugin.md,dsh-plugin.md,releases.md) and CHANGELOG describe the source marker vs unchanged release--release-versionpath;runtime_versionremains the bundled runtime. - New
tests/test_plugin_source_version.pypins unbuilt/built source checkout behavior (Refs #511). - Ready tip green: full-check 3.10/3.11, installed-package, lint-and-smoke, declarations, pr-references (run 44680803479).
Technical/third-party verify only (collaborator permission none) — not a write+ eligible Approver / dual tip / merge-ready under docs/agent-collaboration.md. Merge still needs a write+ independent Approve.
Governing Issue and delivery slice
Refs #511
0.0.0+sourceas the plugin's own version. The three templates carry it, andplugin_versioninruntime/manifest.jsonand in--plugin-infofollows.runtime_versionstill reports the bundled runtime. Regression tests cover all three hosts, and the plugin docs,docs/releases.mdandCHANGELOG.mddescribe the marker.--release-versionvalidation,.github/, ortools/check_release.py. No native-host import or display check.Changed artifacts and evidence
0.0.0+source, no other metadata changeplugins/inferrsi/plugin.json,plugins/workswarm/inferrsi/manifest.json,plugins/inferrsi-dsh/package.json: oneversionline eachtests/test_plugin_source_version.py::test_templates_carry_the_source_marker: 3 passed_version.py: top-level metadata,runtime/manifest.jsonand--plugin-info(Codex, WorkSwarm, DSH)plugin_version.test_source_build_reports_the_marker_beside_the_bundled_runtime[unbuilt-*]: 3 passed. Expects0.0.0+sourcefor the plugin and0+unknownforruntime_version._version.pyand no--release-versiontest_source_build_reports_the_marker_beside_the_bundled_runtime[built-*]: 3 passed. Expects0.0.0+sourcefor the plugin and0.2.0forruntime_version.--release-versionkeeps release valuestest_release_build_keeps_stamping_the_matching_runtime_version: 2 passed--release-versionrejected before outputtest_release_build_rejects_a_version_other_than_the_runtime: 4 passed (both hosts, with and without a generated version). Also checks that no directory or ZIP is left behind.0.0.0+sourceand is not a releasedocs/codex-plugin.md,docs/workswarm-plugin.md,docs/dsh-plugin.md,docs/releases.md,CHANGELOG.mdtests/test_codex_plugin.pystayHost schemas.
https://agent-plugins.org/schemas/1.0.0/plugin.schema.json, fetched during this work, declaresversiononly as"type": "string". It does not reject build metadata.package.jsonis an npm-style manifest. Thesemverpackage bundled with npm parses0.0.0+sourceas valid. DSH's own manifest loader was not run.manifest.jsonin the repository and did not check one elsewhere. Its manifestversionis not validated by any code in this repo that I found.I know of no host whose schema rejects the value, but I did not verify any native host import or display.
Mutation check. With the three templates temporarily restored to
0.1.0,0.1.0and0.0.0, 9 of the 15 new tests failed, so they do constrain the source version. The templates were then put back to0.0.0+source.Checks and dependencies
python -m pytest tests/test_plugin_source_version.py: 15 passed.python -m pytest tests/test_plugin_source_version.py tests/test_workswarm_plugin.py tests/test_dsh_plugin.py tests/test_resource_migration.py: 40 passed. Node was available, so the DSH form and bridge checks ran.python -m pytest tests/test_codex_plugin.py: 46 passed, 8 failed (see below).ruff check src tests tools: all checks passed.tests/test_codex_plugin.py, all from the local environment and none in version handling. Six (test_comparison_preview_execution_status_and_report, 3 per host) need thegitbinary, which is not installed here. Two (test_returned_skill_paths_survive_process_exit_and_later_invocations[...-reference-...], one per host) start the launcher withpython -I, which cannot see PyYAML installed in the user site, so the launcher reports that PyYAML is required. I did not run these on a baseline checkout, so I have not shown they fail identically without this change.tests/test_release.py: 17 passed, 24 errors. All 24 errors areFileNotFoundError: 'git'from fixture setup, so those tests did not run. It is a release-planning test file that this change does not touch.tools/check_release.pyagainst a built release ZIP were not run. No release build was run, so the release workflow's own checks are unverified here.tools/plugin_bundle.pyandtools/build_dsh_plugin.pycopying the templateversionintoplugin_version, which the tests now pin.tools/check_release.pystill requires the tag version, and release builds still stamp it.Remaining work and Issue closure
0.0.0+sourcevalue is unverified. A clean tag checkout resolving to its tag version stays a separate question, as the decision comment states. The version marker does not identify source content; usecontent_sha256and the source commit for that.Handoff (only when an actual handoff or decision changed)
tests/test_codex_plugin.pyandtests/test_release.pywheregitis available.Knowledge authorship declaration
Posted by Dong-bot, an automated agent acting on behalf of @Dong1017 (always-on-bot, model claude-opus-5-5).