Repository navigation
Conversation
The benchmark line (preparation ports, metric contracts, validators and isolated workers) has no area label, so its Issues cannot state an area at creation. Add it next to the other area:* entries with the agreed description. This changes the checked-in manifest only. It does not create, rename or delete a repository label and does not relabel any Issue or PR; the repository label follows after this manifest merges. Agent-assisted-by: Claude Code / deepseek-v4.1-flash-1017 (author) Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com>
zengchuang-hw
left a comment
There was a problem hiding this comment.
PASS
初次独立检视 1b826b5f → d9cacdb0:仅 .github/labels.json 增加一个不重复的 area:benchmark,分组、字段、命名及 85 字符描述均符合现有校验器。按仓库约定,此 PR 只登记清单;不会自动创建 GitHub label、修改任何对象标签或授予授权。批准前无必修项。
已静态核对完整差异、清单、校验器与 Labels 约定;未运行脚本或查询 CI。
The benchmark line (preparation ports, metric contracts, validators and isolated workers) and the apps line (CLI, Python entrypoints, host inspection, workflows, views and adapters) have no area label, so their Issues cannot state an area at creation. Add both next to the other area:* entries with the agreed descriptions. This changes the checked-in manifest only. It does not create, rename or delete a repository label and does not relabel any Issue or PR; the two repository labels follow after this manifest merges. Agent-assisted-by: Claude Code / deepseek-v4.1-flash-1017 (author) Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com>
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base 1b826b5f9666a8b734000e1eb2990e582cdef876 and head 829945bf0cf734d8258eb569f30dd56d17cddb8b.
Independent third-party technical verify (cursor[bot]; collaborator permission none — not a write+ eligible Approver; does not complete dual tip / merge-ready).
Verified tip diff is only .github/labels.json: adds unique area:benchmark and area:apps under group area, with descriptions within the 1–100 character validator bound (tools/check_labels.py). Manifest uniqueness holds (23 entries). Matches Labels convention: PR registers the manifest only; does not create live GitHub labels.
Ready tip green (full-check 3.10/3.11 + declarations + installed-package + dashboard-browser + pr-references). Prior zengchuang-hw Approve on d9cacdb0… was dismissed by tip move; this is cursor first formal tip vote (author Dong1017 → Dong ineligible).
Merge still needs write+ independent Approves / steward integration — not claimed here.
Governing Issue and delivery slice
Governing Issue: none. This is a label-manifest change requested on its own; task: Benchmark production prepare and frozen resource closure #430 and feat(benchmark): add frozen P1 preparation port #530 are the benchmark work the new labels name, not its acceptance owner, and they are not relabeled here.
Accepted scope / delegation: add two official labels to the checked-in manifest,
area:benchmarkandarea:apps. The repository labels are created from the manifest after this PR merges, per the Labels section ofdocs/agent-collaboration.md.What this PR delivers: two entries in
.github/labels.json, grouped with the otherarea:*entries, each with exactly the fieldsname,groupanddescription:area:benchmark—Benchmark line: preparation ports, metric contracts, validators, and isolated workers(85 characters).area:apps—Apps line: CLI, Python entrypoints, host inspection, workflows, views, and adapters(83 characters).Both are within the 100-character limit
tools/check_labels.pyenforces.What it does not deliver: no repository label is created, renamed or deleted by this PR, and no Issue or PR is relabeled, including feat(benchmark): add frozen P1 preparation port #530 and task: Benchmark production prepare and frozen resource closure #430. Nothing changes in
.github/workflows/ci-nightly.yml,tools/check_labels.pyortests/test_check_labels.py.The repository's stray
high prioritylabel is out of scope here and stays untouched: it is not inlabels.jsonand not added to it.Knowledge authorship declaration
Not applicable.
.github/labels.jsonis outsideprotected_pathsandpolicy_pathsin.github/knowledge-model-policy.json. The block below is disclosure only.Changed artifacts and evidence
.github/labels.json:area:benchmarkafterarea:harness,area:appsafterarea:benchmarkpytest tests/test_check_labels.py: 40 passed.manifest_problemsreturns no problem; the JSON parses; the 23 names are uniquetools/skill_eval_*_config.jsonnames either new label;area:*stays a group reference in the guidetools/check_labels.pyagainst the live label list reports onlyarea:benchmark: in labels.json, missing from the repositorysafety-netjob cannot be green until the repository labels exist; that step follows the mergegit diff --stat d9cacdb0: 1 file, 5 insertionsgit diff --checkcleanChecks and dependencies
python -m pytest tests/test_check_labels.py -q(40 passed) locally; JSON parse of.github/labels.jsonwith the 23 names, per-entry description lengths and a uniqueness assertion;tools/check_labels.pyagainst a live label listing;git diff --check.ruffwere not run locally; CI covers them.area:*label is applied by the creator at creation, so existing Issues are unaffected by the omission.d9cacdb0carried one approval. Commit829945bfreplaces it and the repository dismisses approvals on push, so both approvals must be re-earned at the new head.Remaining work and Issue closure
area:benchmarkto feat(benchmark): add frozen P1 preparation port #530 and task: Benchmark production prepare and frozen resource closure #430.