Repository navigation
Conversation
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject an entire native Vela 0.8B request when any completed ordinary or span-window row exceeds 16,384 tokens. The previous renderer could admit a 16,385-token row or 16,443-token windows, and a sufficiently long span header panicked in debug during unsigned budget subtraction.
This is a stacked supplement to #175. Base
codex/vela175-processing-baseis pinned to MrDongsls'scdff2999b9e082e246f933235b608d7a7e5978b2; head1d460564165310498a1c3d8afddbdc202b4d0dfepreserves that history. Five files, +287/-4, including 249 changed Rust lines. Retarget/integrate after the author stack lands and recheck. The recipe manifest-anchor fix already in #205 is not duplicated.Required human contributor answers
The contributor explicitly confirmed the common scope on 2026-11-19 and the per-row 16,384-token cap with explicit 413 on 2026-11-20; the detailed confirmation is retained in the contributor's task record.
Is a PR needed? Yes. The contributor authorized necessary stage draft PRs and independent supplements preserving other authors' commits.
Bug evidence: The new root regressions fail against the original #175 implementation before the production change; concrete output is recorded below.
Purpose
Use safe budget arithmetic, enforce a final row bound at the renderer shared by ordinary/window paths, and document the native input subset. State clipping, windowing, question order and usage accounting remain intact; valid requests may sum more than 16,384 input tokens across rows. The manifest remains the pinned 0.8B
max_length=16384identity.This is an intentional restriction relative to the pinned Python runtime: the captured long-span request reaches its model-call boundary with a 20,085-token row. Native returns 413. The reference was intercepted before forward; successful inference and HTTP behavior were not established. Existing non-finite-JSON wording and multi-part-span differences remain explicit.
Evidence
Test Plan
Version / commit:
1d460564165310498a1c3d8afddbdc202b4d0dfe, tree060b317326271fe62286e2a6c0887715417dde9c; tested source tree matched on local and L20 checkouts.From repository root:
Ordinary tests use a tiny local tokenizer at the real processor seam and need no checkpoint, download or GPU. Test bodies stay under root tests; src contains only cfg/path registration.
Test Result
Demo / evidence
Model/runtime/tokenizer:
vllm-sr/Vela-2.0-0.8B@326b01d81f61fff7fd4ae570e54b87a49119e490. Existing source shard SHA256c70237ecd579c60289c177fa9806e71c24840c2fc557b5c76af1395dc3081fa6; unchanged flat-bundle manifest anchora41d87ddfc561551f24632e03e1b3fa7617004b05785f024f4b364df131a010f. Rust1.100.0, Python3.12.13, torch2.11.0+cpu, transformers5.19.0, Python tokenizers0.23.2, numpy2.5.3 and safetensors0.8.0.The comparator still records the reference's 20,085-token row and exact native 413. Its cap exception is limited to that approved out-of-domain observation; all in-domain mismatches fail. The five frozen fixtures, field/order/usage assertions and numerical gates are unchanged. Example usage remains1041/0.
Full raw stdout, baseline failures, source/binary/fixture hashes and scripts are retained off-repo in
vela175-cap-evidence.tar.gz, SHA256caa8e30577e605bcb102155ad6cd6414d6ef6ad32a9957f20ae5eac2bcfaad5e. Earlier blocked-stage evidence is preserved separately. No generated logs/archive are added to product Git.Unrun: model forward, native HTTP, GPU, #176 head numerics and later executor stages. No accuracy/performance claim; a video or GPU campaign is not needed for this input-contract slice.
Merge Danger
Door: two-way.
Blast Radius: contract.
Native Vela's admitted row domain is now explicit. The original author branch is untouched; later slices must incorporate this supplement before relying on the accepted input prerequisite.
Self-review
Agent precheck covered the complete five-file diff, ownership, root-test discovery, red/green evidence, exact real-package replay, documentation and artifact hygiene. Keep draft; contributor/maintainer review remains separate.