infs build projects

[0xGeorgii]

Closes #222

Confidence Score: 5/5

Safe to merge — the new project-mode dispatch, ABI handshake, and output-dir forwarding logic are well-structured and thoroughly tested.

All new code paths have both unit tests and integration tests exercising success and failure branches. The only gap is the exists() vs is_file() inconsistency in the single-file guards, a UX quality issue on uncommon input rather than a correctness regression.

apps/infs/src/commands/build.rs and apps/infs/src/commands/run.rs — the single-file path.exists() guards are inconsistent with the is_file() guard established in project_build.rs.

Important Files Changed

Filename	Overview
apps/infs/src/commands/project_build.rs	New shared project-build helper: resolves entry point with is_file(), drives the ABI handshake, and gates --out-dir forwarding on CompilerCompat::supports_out_dir(). Well-structured and thoroughly unit-tested.
apps/infs/src/commands/build.rs	Gains project-mode dispatch; execute_single_file still uses path.exists() instead of path.is_file(), inconsistent with the is_file() guard established in project_build.rs.
apps/infs/src/commands/run.rs	Gains project-mode dispatch via run_project_build(None, None); same path.exists() inconsistency as build.rs in the single-file guard.
apps/infs/src/project/manifest.rs	Adds BuildConfig.mode, VerificationConfig.output_dir, and thorough validation/normalization logic. Path-traversal and absolute-path guards in normalized_output_dir are correct and well-tested.
apps/infs/tests/cli_integration.rs	Comprehensive new integration tests covering project build, project run, manifest semantics, ABI capability gating, and scaffolding round-trips.
core/compiler-interface/src/lib.rs	ABI minor bumped from 0 to 1 to advertise --out-dir support; clear backward-compatibility note in the doc comment.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["infs build / infs run"] --> B{path arg present?}
    B -- yes --> C[execute_single_file]
    B -- no --> D[discover_and_load cwd]
    D --> E{Inference.toml found?}
    E -- no --> F[error: manifest not found]
    E -- yes --> G[ProjectContext]
    G --> H[run_project_build]
    H --> I{src/main.inf is_file?}
    I -- no --> J[error: missing entry point]
    I -- yes --> K[probe_compiler_compatibility]
    K --> L{commit hash match?}
    L -- yes --> M[CompilerCompat commit_matched=true]
    L -- no --> N[probe --abi-version]
    N --> O{major mismatch?}
    O -- yes --> P[hard error: rebuild toolchain]
    O -- no --> Q[CompilerCompat with abi]
    M --> R{out_dir requested?}
    Q --> R
    R -- no --> U[infc default out/]
    R -- yes --> T{supports_out_dir?}
    T -- no --> S[hard error: ABI too old]
    T -- yes --> V[infc --out-dir dir]
    V --> W[propagate exit code]
    U --> W
    C --> X[path.exists check]
    X --> Y[find_infc + check_compat]
    Y --> Z[infc subprocess]
    Z --> W

Loading

Comments Outside Diff (1)

1. apps/infs/tests/cli_integration.rs, line 3102-3129 (link)

   Proof-mode tests implicitly require infc ABI ≥ 1.1

   project_build_manifest_proof_writes_under_proofs, project_build_proof_honors_custom_output_dir, project_build_cli_proof_on_default_manifest_uses_proofs, and project_build_cli_compile_overrides_manifest_proof all trigger the --out-dir forwarding path. They are gated only on require_infc() (infc present), not on the ABI version. If run against an infc that reports ABI 1.0 — e.g. a developer pointing INFC_PATH at an older local build — run_project_build will hard-error with the capability message rather than succeed, and these tests fail instead of being skipped. Adding an ABI-version pre-check (query --abi-version, parse it, skip if minor < 1) would make the skip behaviour consistent with the rest of the conditional test pattern.

_{Reviews (3): Last reviewed commit: "update docs" | Re-trigger Greptile}

[Copilot]

Pull request overview

This PR makes infs build / infs run project-aware (cargo-style): when no .inf path is provided, it discovers Inference.toml, builds src/main.inf from the project root, and (for run) executes out/main.wasm. To support project-root output placement and manifest-driven proof artifacts, it adds an infc --out-dir <path> flag and bumps the compiler ABI minor version.

Changes:

• Add --out-dir <path> to infc, bump compiler ABI minor to 1.1, and add integration tests for output redirection semantics.
• Implement project discovery/loading in infs (walk up for Inference.toml), plus a shared project-build helper used by both build and run.
• Extend manifest/scaffolding to include explicit [build] mode, honor [verification] output-dir in proof builds, and add broad CLI integration coverage for project mode.

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
core/compiler-interface/src/lib.rs	Bumps ABI minor to 1 and documents the new additive flag.
core/cli/src/parser.rs	Adds --out-dir CLI flag to infc.
core/cli/src/main.rs	Uses out_dir (or default out/) when writing artifacts.
core/cli/tests/cli_integration.rs	Adds integration tests for ABI string and --out-dir behavior.
apps/infs/src/project/manifest.rs	Adds [build] mode, manifest load/discovery helpers, and output-dir normalization.
apps/infs/src/project/mod.rs	Introduces ProjectContext and discover_and_load.
apps/infs/src/project/scaffold.rs	Scaffolds explicit [build] mode = "compile" and ignores generated proof artifacts.
apps/infs/src/commands/project_build.rs	New shared helper for project-mode build: warnings, handshake, spawning infc from project root.
apps/infs/src/commands/build.rs	Makes path optional (project mode), resolves effective mode/output-dir, delegates to project helper.
apps/infs/src/commands/run.rs	Makes path optional (project mode), project-run pipeline builds then runs <root>/out/main.wasm.
apps/infs/src/commands/mod.rs	Registers the new project_build module.
apps/infs/src/commands/new.rs	Updates “next steps” to infs build (project mode).
apps/infs/src/commands/init.rs	Updates “next steps” to infs build (project mode).
apps/infs/src/main.rs	Updates CLI help text to describe project-mode run behavior.
apps/infs/tests/cli_integration.rs	Adds extensive project-mode build/run + manifest semantics integration tests.
.gitignore	Ignores /scratch.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.

[codecov]

Codecov Report

❌ Patch coverage is 92.52925% with 83 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
apps/infs/src/commands/run.rs	61.76%	39 Missing ⚠️
apps/infs/src/commands/project_build.rs	90.85%	31 Missing ⚠️
apps/infs/src/commands/build.rs	94.87%	6 Missing ⚠️
apps/infs/src/project/mod.rs	95.77%	3 Missing ⚠️
apps/infs/src/project/manifest.rs	99.54%	2 Missing ⚠️
core/cli/src/main.rs	75.00%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!