Conversation
Infernno
force-pushed
the
feature/jenkins
branch
from
85d7186 to
545ae11
Compare
Infernno
force-pushed
the
feature/jenkins
branch
from
d9bc809 to
b8670c2
Compare
antonkazakov
left a comment
antonkazakov
left a comment
There was a problem hiding this comment.
Привет. Работу засчитываю, но обрати внимание на замечание про креды, ни в коем случае нельзя хранить сенситив информацию в репозитории и тем более в открытом виде
| @@ -0,0 +1,2 @@ | |||
| alias=gamehub | |||
There was a problem hiding this comment.
А почему ты релизный кейстор и креды к нему положил в репозиторий? Это совершенно небезопасно, нужно было положить в креды и организовать биндинг https://plugins.jenkins.io/credentials-binding/
| post { | ||
| failure { | ||
| script { | ||
| if (getContext(hudson.FilePath)) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.