Skip to content

Revert PR #153 (instance-level 'member' → 'admin' rename)#156

Merged
dangtony98 merged 1 commit intomainfrom
revert-instance-role-admin
May 8, 2026
Merged

Revert PR #153 (instance-level 'member' → 'admin' rename)#156
dangtony98 merged 1 commit intomainfrom
revert-instance-role-admin

Conversation

@dangtony98
Copy link
Copy Markdown
Contributor

@dangtony98 dangtony98 commented May 8, 2026

Summary

Reverts #153, which renamed the instance-level role from member to admin on users, agents, invites, and user_invites. We're keeping the instance-level role name as member.

Pure git revert b608427 — restores Go server, CLI, web UI, tests, and docs to the pre-#153 wording, and deletes internal/store/migrations/044_instance_role_admin.sql from the source tree. No inverse migration is needed because nothing built on b608427 or later was ever distributed, so no DB has applied migration 044. Fresh installs from this branch run migrations …042 → 043 and stop there.

PR #155 (fresh-checkout go test fix) is preserved untouched — it only modified .gitignore and internal/server/webdist/.gitkeep, neither of which overlap with #153.

Test plan

  • go test ./... passes (store, server, cmd)
  • go build ./... clean
  • Smoke: fresh install on this branch → schema matches pre-roles: rename instance-level 'member' to 'admin' #153 state
  • Smoke: agent-vault user invite foo@bar.com defaults to member; --role owner still works; --role admin rejected
  • Smoke: web invite-user / invite-agent dialogs show "Member" / "Owner"; toggle in users tab demotes owner → member (and is blocked for last owner)

@infisical-review-police
Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-agent-vault-156-revert-pr-153-instance-level-member-admin-rename

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@mintlify
Copy link
Copy Markdown

mintlify Bot commented May 8, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
agent-vault 🟢 Ready View Preview May 8, 2026, 9:48 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@dangtony98 dangtony98 force-pushed the revert-instance-role-admin branch from 04f8d3e to f20be9c Compare May 8, 2026 21:52
@dangtony98 dangtony98 merged commit d33de92 into main May 8, 2026
9 checks passed
@dangtony98 dangtony98 deleted the revert-instance-role-admin branch May 8, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant