Revert PR #153 (instance-level 'member' → 'admin' rename)#156
Merged
dangtony98 merged 1 commit intomainfrom May 8, 2026
Merged
Revert PR #153 (instance-level 'member' → 'admin' rename)#156dangtony98 merged 1 commit intomainfrom
dangtony98 merged 1 commit intomainfrom
Conversation
This reverts commit b608427.
|
💬 Discussion in Slack: #pr-review-agent-vault-156-revert-pr-153-instance-level-member-admin-rename Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
04f8d3e to
f20be9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #153, which renamed the instance-level role from
membertoadminonusers,agents,invites, anduser_invites. We're keeping the instance-level role name asmember.Pure
git revert b608427— restores Go server, CLI, web UI, tests, and docs to the pre-#153 wording, and deletesinternal/store/migrations/044_instance_role_admin.sqlfrom the source tree. No inverse migration is needed because nothing built onb608427or later was ever distributed, so no DB has applied migration 044. Fresh installs from this branch run migrations…042 → 043and stop there.PR #155 (fresh-checkout
go testfix) is preserved untouched — it only modified.gitignoreandinternal/server/webdist/.gitkeep, neither of which overlap with #153.Test plan
go test ./...passes (store, server, cmd)go build ./...cleanagent-vault user invite foo@bar.comdefaults tomember;--role ownerstill works;--role adminrejected