Skip to content

Update openai with responses api#337

Open
ericelskenpmg wants to merge 6 commits into
Ingenimax:mainfrom
AgencyPMG:eric/openai-responses-reasoning-tools-json
Open

Update openai with responses api#337
ericelskenpmg wants to merge 6 commits into
Ingenimax:mainfrom
AgencyPMG:eric/openai-responses-reasoning-tools-json

Conversation

@ericelskenpmg

Copy link
Copy Markdown

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

ericelsken and others added 3 commits June 4, 2026 12:46
- Updated dependencies version.
…new-way-to-accept-reasoning-and-thinking-condition

Allow reasoning config while working with tools calling
@meidad

meidad commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Thanks for this — Responses API support is genuinely useful, especially for file inputs and reasoning models. A few things before merging:

Required

  1. Fill out the PR description. The body is blank and all checklist items are unchecked. Please describe what changed and how you tested it.

  2. Auto-activation behavior. It looks like shouldUseResponsesAPI may auto-route reasoning models (o1/o3/o4 series) through the Responses API even without WithResponsesAPI(true). If so, that's a silent behavior change for existing reasoning model users. Please make it fully opt-in, or at minimum document the auto-activation prominently.

  3. FileInputs in shared interface. Adding FileInputs to GenerateOptions in pkg/interfaces/llm.go affects all providers. Anthropic, Gemini, and DeepSeek will silently ignore these inputs. That's acceptable, but each provider's Generate/GenerateWithTools should log a warning or return an error when FileInputs is non-empty and the provider doesn't support it. Silent no-ops are hard to debug.

Nice-to-have

  1. A short example in examples/ showing Responses API + file input end-to-end would be helpful for users.

Happy to merge once items 1–3 are addressed.

@meidad meidad mentioned this pull request Jun 12, 2026
9 tasks
khanhluu1995 and others added 3 commits June 12, 2026 00:37
…t.format) to both paths, matching chat parity exactly (non-stream: loop+final; stream: final-only).

- generateWithToolsResponsesStream (responses.go), dispatched from GenerateWithToolsStream via same shouldUseResponsesAPI gate. Mirrors chat-stream event contract (MessageStart → ContentDelta/ToolUse/ToolResult → ContentComplete → MessageStop), filterIntermediateContent replay, tool-exec between streamed turns, previous_response_id chaining. This is the path genworkflow create+MCP actually hits.
…ter-match

OpenAI new endpoint for tool call with stream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants