Skip to content

fix(security): close #140 — migrate constant-only commons-httpclient callers to org.apache.http (SEC-03) #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NSchatz wants to merge 7 commits into
base: bridgelink_development
Choose a base branch
from
Open

fix(security): close #140 — migrate constant-only commons-httpclient callers to org.apache.http (SEC-03) #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9d4a9e2
fix(140): migrate HttpReceiver.java to org.apache.http imports
NSchatz May 14, 2026
47835ac
fix(140): migrate MirthWebServer.java to org.apache.http imports
NSchatz May 14, 2026
51c12a2
fix(140): migrate ConnectServiceUtil.java to org.apache.http imports
NSchatz May 14, 2026
cd998d0
chore(140): document deferred httpclient migration in WebDavConnectio…
NSchatz May 14, 2026
14d24f9
chore(140): document deferred httpclient migration in HTTPUtil.java
NSchatz May 14, 2026
32e3d5e
docs(140): disclose residual commons-httpclient classpath exposure in…
NSchatz May 14, 2026
0b7e0ae
docs(140): correct contradictory residual-CVE statement in SECURITY.m…
NSchatz May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions SECURITY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,17 @@ We support the current minor version in regards to security updates. Versions ar
If this is a critical vulnerability that you would like to contact us confidentially, email us here:

ossteam@innovarhealthcare.com

## Known residual dependencies

- `commons-httpclient-3.0.1.jar` remains on the server classpath for runtime
resolution of two deferred call sites:
- `WebDavConnection.java` (`HttpURL` / `HttpsURL` — blocked on Apache Slide
replacement; tracked under SEC-V2-01).
- `HTTPUtil.java` (`Header` / `HttpParser` — blocked on `HttpParser.parseHeaders`
equivalent in `org.apache.http`; tracked under SEC-V2-01 companion).

All other constant-only callers (`HttpReceiver.java`, `MirthWebServer.java`,
`ConnectServiceUtil.java`) were migrated in #140. The jar carries unfixed
CVE-2012-5783, CVE-2014-3577, and CVE-2015-5262 (MITM / hostname-verification);
exposure is bounded to the two WebDAV/HTTP utility call sites above.
2 changes: 1 addition & 1 deletion server/src/com/mirth/connect/client/core/ConnectServiceUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import java.util.Map;
import java.util.Set;

import org.apache.commons.httpclient.HttpStatus;
import org.apache.http.HttpStatus;
import org.apache.commons.io.IOUtils;
import org.apache.http.HttpEntity;
import org.apache.http.NameValuePair;
Expand Down
1 change: 1 addition & 0 deletions server/src/com/mirth/connect/connectors/file/filesystems/WebDavConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import java.util.List;
import java.util.Map;

// TODO: migrate to Sardine; blocked by Apache Slide dependency (SEC-V2-01)
import org.apache.commons.httpclient.HttpURL;
import org.apache.commons.httpclient.HttpsURL;
import org.apache.commons.io.filefilter.WildcardFileFilter;
Expand Down
2 changes: 1 addition & 1 deletion server/src/com/mirth/connect/connectors/http/HttpReceiver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
import org.apache.commons.collections4.CollectionUtils;
import org.apache.commons.collections4.ListUtils;
import org.apache.commons.fileupload.servlet.ServletFileUpload;
import org.apache.commons.httpclient.HttpStatus;
import org.apache.http.HttpStatus;
import org.apache.commons.io.IOUtils;
import org.apache.commons.lang3.StringUtils;
import org.apache.commons.lang3.exception.ExceptionUtils;
Expand Down
2 changes: 1 addition & 1 deletion server/src/com/mirth/connect/server/MirthWebServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@

import org.apache.commons.collections4.CollectionUtils;
import org.apache.commons.configuration2.PropertiesConfiguration;
import org.apache.commons.httpclient.HttpStatus;
import org.apache.http.HttpStatus;
import org.apache.commons.io.FileUtils;
import org.apache.commons.io.IOUtils;
import org.apache.commons.io.filefilter.FalseFileFilter;
Expand Down
1 change: 1 addition & 0 deletions server/src/com/mirth/connect/server/userutil/HTTPUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import javax.xml.parsers.ParserConfigurationException;

import org.apache.commons.fileupload.FileUploadBase;
// TODO: migrate to org.apache.http; blocked on HttpParser equivalent (SEC-V2-01 companion)
import org.apache.commons.httpclient.Header;
import org.apache.commons.httpclient.HttpParser;
import org.apache.commons.io.IOUtils;
Expand Down