fix: resolve npx executable resolution for @insforge/mcp#49
fix: resolve npx executable resolution for @insforge/mcp#49tonychang04 wants to merge 1 commit intomasterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughPackage version bumped from 1.2.7 to 1.2.8. Added Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/http/.claude/settings.local.json`:
- Around line 1-5: The file settings.local.json was accidentally committed
despite being listed in .gitignore; remove it from git tracking by running git
rm --cached for that file (do not delete the local file), commit the removal
with a clear message, and push; also verify the .gitignore entry for the
.claude/settings.local.json pattern remains present so the file won’t be
re-added.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9011d91f-fb98-4c79-94b0-0dcab5334cb0
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
package.jsonsrc/http/.claude/settings.local.json
Adding a second bin entry in 7bd5c79 broke `npx -y @insforge/mcp` because npx can't auto-select an executable when multiple bin entries exist and none match the unscoped package name. Also fixes the incorrect bin path for insforge-mcp-server (dist/http/server.js → dist/http-server.js). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
0bfddcf to
bbfe061
Compare
Summary
mcpbin entry matching the unscoped package name sonpx -y @insforge/mcpcan resolve the executable when multiple bin entries existinsforge-mcp-serverbin path (dist/http/server.js→dist/http-server.js) to match actual tsup build outputContext
Commit 7bd5c79 added a second bin entry (
insforge-mcp-server), which brokenpx -y @insforge/mcp@1.2.7with "could not determine executable to run". With a single bin entry, npx auto-selects it; with multiple, it looks for one matching the unscoped package name (mcp).Test plan
npx -y @insforge/mcpresolves and starts the MCP servernpx insforge-mcpstill worksnpx insforge-mcp-serverstarts the HTTP server🤖 Generated with Claude Code
Note
Fix
npxexecutable resolution for@insforge/mcpby correcting bin pathsmcpfield in package.json pointing to./dist/index.jsto supportnpxresolution.insforge-mcp-serverbin target from./dist/http/server.jsto./dist/http-server.jsto match the actual build output path.Macroscope summarized bbfe061.
Summary by CodeRabbit