Skip to content

fix: resolve npx executable resolution for @insforge/mcp#49

Open
tonychang04 wants to merge 1 commit intomasterfrom
fix/npx-executable-resolution
Open

fix: resolve npx executable resolution for @insforge/mcp#49
tonychang04 wants to merge 1 commit intomasterfrom
fix/npx-executable-resolution

Conversation

@tonychang04
Copy link
Copy Markdown
Contributor

@tonychang04 tonychang04 commented Mar 28, 2026

Summary

  • Add mcp bin entry matching the unscoped package name so npx -y @insforge/mcp can resolve the executable when multiple bin entries exist
  • Fix incorrect insforge-mcp-server bin path (dist/http/server.jsdist/http-server.js) to match actual tsup build output
  • Bump version to 1.2.8

Context

Commit 7bd5c79 added a second bin entry (insforge-mcp-server), which broke npx -y @insforge/mcp@1.2.7 with "could not determine executable to run". With a single bin entry, npx auto-selects it; with multiple, it looks for one matching the unscoped package name (mcp).

Test plan

  • npx -y @insforge/mcp resolves and starts the MCP server
  • npx insforge-mcp still works
  • npx insforge-mcp-server starts the HTTP server

🤖 Generated with Claude Code

Note

Fix npx executable resolution for @insforge/mcp by correcting bin paths

  • Adds a top-level mcp field in package.json pointing to ./dist/index.js to support npx resolution.
  • Changes the insforge-mcp-server bin target from ./dist/http/server.js to ./dist/http-server.js to match the actual build output path.
  • Bumps version to 1.2.8.

Macroscope summarized bbfe061.

Summary by CodeRabbit

  • Chores
    • Bumped package version to 1.2.8
    • Reorganized executable entry points for improved command-line tool consistency and accessibility

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 62bb7147-dc2b-4b21-b319-120d51b8fd2c

📥 Commits

Reviewing files that changed from the base of the PR and between 0bfddcf and bbfe061.

📒 Files selected for processing (1)
  • package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json

Walkthrough

Package version bumped from 1.2.7 to 1.2.8. Added mcp executable in bin entrypoints and corrected insforge-mcp-server path from ./dist/http/server.js to ./dist/http-server.js. The insforge-mcp entrypoint remains pointing to ./dist/index.js.

Changes

Cohort / File(s) Summary
Package Configuration
package.json
Version bumped to 1.2.8; added mcp bin entrypoint; corrected insforge-mcp-server path from ./dist/http/server.js to ./dist/http-server.js.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Possibly related PRs

  • Devel #16: Shares package.json modifications with overlapping packaging metadata updates.

Suggested reviewers

  • Fermionic-Lyu
  • jwfing
  • Leo-rq-yu

Poem

🐰 Hopping versions with a gentle bound,
From 1.2.7 to 1.2.8 we've found,
Bin entrypoints corrected with care,
Now the mcp command flies through the air! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: adding a new mcp bin entry to resolve npx executable resolution, which is the core issue addressed in this PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/npx-executable-resolution

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/http/.claude/settings.local.json`:
- Around line 1-5: The file settings.local.json was accidentally committed
despite being listed in .gitignore; remove it from git tracking by running git
rm --cached for that file (do not delete the local file), commit the removal
with a clear message, and push; also verify the .gitignore entry for the
.claude/settings.local.json pattern remains present so the file won’t be
re-added.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9011d91f-fb98-4c79-94b0-0dcab5334cb0

📥 Commits

Reviewing files that changed from the base of the PR and between 7fa2796 and 0bfddcf.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json
  • src/http/.claude/settings.local.json

honoyomu
honoyomu previously approved these changes Mar 28, 2026
Adding a second bin entry in 7bd5c79 broke `npx -y @insforge/mcp` because
npx can't auto-select an executable when multiple bin entries exist and
none match the unscoped package name. Also fixes the incorrect bin path
for insforge-mcp-server (dist/http/server.js → dist/http-server.js).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants