feat(itkwasm): add pyodide support for TransformList#1406
Merged
thewtex merged 5 commits intoInsightSoftwareConsortium:mainfrom Jun 26, 2025
Merged
feat(itkwasm): add pyodide support for TransformList#1406thewtex merged 5 commits intoInsightSoftwareConsortium:mainfrom
thewtex merged 5 commits intoInsightSoftwareConsortium:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for converting lists of Transform objects (a TransformList) between Python and JavaScript in Pyodide.
- Extended
to_jsandto_pyinpyodide.pyto detect and handle lists ofTransforminstances. - Imported
TransformListand updated array conversion logic. - Added an end-to-end Pyodide test
test_transform_list_conversionthat round-trips aTransformList.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/python/itkwasm/test/test_pyodide.py | New async test for TransformList conversion in Pyodide environment. |
| packages/core/python/itkwasm/itkwasm/pyodide.py | Imports and conversion logic for serializing/deserializing TransformList. |
Comments suppressed due to low confidence (2)
packages/core/python/itkwasm/test/test_pyodide.py:274
- Add an assertion for
translation_py.fixedParametersto verify thatfixedParametersis correctly converted to an empty array.
np.testing.assert_allclose(translation_py.parameters, translation_parameters)
packages/core/python/itkwasm/itkwasm/pyodide.py:8
- The imported
TransformListalias is not referenced in this module and can be removed to avoid an unused import.
from .transform import Transform, TransformType, TransformList
e98c726 to
6a58abc
Compare
Unnecessary complexity and overhead.
…onverter For better support for the JSONCompatible interface type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.