COMP: Update LesionSizingToolkit remote module pin#6663
Merged
hjmjohnson merged 1 commit intoJul 20, 2026
Merged
Conversation
Picks up the test-name renames that resolve the duplicate-test-name AUTHOR_WARNINGs against ITK's ImageGradient and ImageFeature modules, and the missing itkImageRegionIteratorWithIndex.h include without which the module does not compile against current ITK.
hjmjohnson
marked this pull request as ready for review
July 18, 2026 21:27
Contributor
|
| Filename | Overview |
|---|---|
| Modules/Remote/LesionSizingToolkit.remote.cmake | Updates the LesionSizingToolkit remote module GIT_TAG to a newer pinned commit; no issues found in the remote module declaration. |
Reviews (1): Last reviewed commit: "COMP: Update LesionSizingToolkit to 29ae..." | Re-trigger Greptile
dzenanz
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the pinned LesionSizingToolkit commit to pick up two fixes: the test-name renames that clear the duplicate-test-name
AUTHOR_WARNINGs on the nightly dashboards, and a missing#includewithout which the module does not compile against current ITK.Note for dashboard maintainers:
Module_LesionSizingToolkit_GIT_TAGis cached per build tree and shadows this file's default, so a persistent build tree will keep fetching the old commit after this merges until that cache entry is cleared (cmake -UModule_LesionSizingToolkit_GIT_TAG <build>) or the tree is wiped.What the bump picks up
affbf7b095…→29ae0f95a2ffd3cc65d50305a141b5c5f9bebb3e(5 commits):The first two are the reason for this bump:
8a02cdbrenamesitkGradientMagnitudeImageFilterTest1anditkCannyEdgeDetectionImageFilterTest2, which ITK core already registers inFiltering/ImageGradientandFiltering/ImageFeature. Beyond the warning, duplicate names share ITK'sCleanup_<name>fixture and race underctest -j.29ae0f9adds#include "itkImageRegionIteratorWithIndex.h"to two files that used the type but relied on transitive inclusion current ITK no longer provides. Without it, 8 translation units fail to compile.Verification
Release, AppleClang, arm64, macOS 26.5 SDK,
-DModule_LesionSizingToolkit=ON, against this branch.Duplicate test namewarnings at configureLesionSizingToolkit-all(library + test driver)src/executablesctestover the module's test directoryResulting test registrations — four distinct names where two collided:
The module's
src/executables are not part of theLesionSizingToolkit-alltarget group and were built explicitly, since97f8358changes exactly their link libraries.