Skip to content

COMP: Update LesionSizingToolkit remote module pin#6663

Merged
hjmjohnson merged 1 commit into
InsightSoftwareConsortium:mainfrom
hjmjohnson:bump-lesionsizingtoolkit-pin
Jul 20, 2026
Merged

COMP: Update LesionSizingToolkit remote module pin#6663
hjmjohnson merged 1 commit into
InsightSoftwareConsortium:mainfrom
hjmjohnson:bump-lesionsizingtoolkit-pin

Conversation

@hjmjohnson

Copy link
Copy Markdown
Member

Update the pinned LesionSizingToolkit commit to pick up two fixes: the test-name renames that clear the duplicate-test-name AUTHOR_WARNINGs on the nightly dashboards, and a missing #include without which the module does not compile against current ITK.

Note for dashboard maintainers: Module_LesionSizingToolkit_GIT_TAG is cached per build tree and shadows this file's default, so a persistent build tree will keep fetching the old commit after this merges until that cache entry is cleared (cmake -UModule_LesionSizingToolkit_GIT_TAG <build>) or the tree is wiped.

What the bump picks up

affbf7b095…29ae0f95a2ffd3cc65d50305a141b5c5f9bebb3e (5 commits):

29ae0f9 COMP: Include itkImageRegionIteratorWithIndex.h where the type is used
8a02cdb COMP: Rename test names that collide with ITK core tests
97f8358 ENH: Use modern ITK interface libraries for executables
8d5cba9 BUG: Fix IsotropicResamplerImageFilter wrapping template arguments
28d74fd COMP: Update CI to ITKRemoteModuleBuildTestPackageAction v5.4.6 and Python 3.10+

The first two are the reason for this bump:

  • 8a02cdb renames itkGradientMagnitudeImageFilterTest1 and itkCannyEdgeDetectionImageFilterTest2, which ITK core already registers in Filtering/ImageGradient and Filtering/ImageFeature. Beyond the warning, duplicate names share ITK's Cleanup_<name> fixture and race under ctest -j.
  • 29ae0f9 adds #include "itkImageRegionIteratorWithIndex.h" to two files that used the type but relied on transitive inclusion current ITK no longer provides. Without it, 8 translation units fail to compile.
Verification

Release, AppleClang, arm64, macOS 26.5 SDK, -DModule_LesionSizingToolkit=ON, against this branch.

Stage Before (old pin) After (new pin)
Duplicate test name warnings at configure 2 0
LesionSizingToolkit-all (library + test driver) 10 failing targets 0
10 src/ executables 0 failures
ctest over the module's test directory not reachable (module did not build) 41/41 passed, exit 0

Resulting test registrations — four distinct names where two collided:

#1792 itkCannyEdgeDetectionImageFilterTest2                   (ITK core)
#1933 itkGradientMagnitudeImageFilterTest1                    (ITK core)
#3722 LesionSizingToolkitGradientMagnitudeImageFilterTest1    (remote module)
#3729 LesionSizingToolkitCannyEdgeDetectionImageFilterTest2   (remote module)

The module's src/ executables are not part of the LesionSizingToolkit-all target group and were built explicitly, since 97f8358 changes exactly their link libraries.

Picks up the test-name renames that resolve the duplicate-test-name
AUTHOR_WARNINGs against ITK's ImageGradient and ImageFeature modules, and
the missing itkImageRegionIteratorWithIndex.h include without which the
module does not compile against current ITK.
@github-actions github-actions Bot added type:Compiler Compiler support or related warnings area:Remotes Issues affecting the Remote module labels Jul 18, 2026
@hjmjohnson
hjmjohnson marked this pull request as ready for review July 18, 2026 21:27
@greptile-apps

greptile-apps Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the LesionSizingToolkit remote module pin. The main changes are:

  • Replaces the pinned GIT_TAG with commit 29ae0f95a2ffd3cc65d50305a141b5c5f9bebb3e.
  • Keeps the same remote repository, module name, and compliance level.
  • Pulls in upstream build and test-registration fixes for the remote module.

Confidence Score: 5/5

Safe to merge with minimal risk.

The changeset is a single remote-module SHA bump with the repository, module name, and compliance settings unchanged.

No files require special attention.

T-Rex T-Rex Logs

What T-Rex did

  • Verified that essential build tools and dependencies were unavailable at first and then made cmake, ctest, ninja, make, git, gcc, and python3 available, with the remote pin set to 29ae0f95a2ffd3cc65d50305a141b5c5f9bebb3e.
  • Validated that the upstream reference now points to LesionSizingToolkit.git, the old tag was replaced by a new commit, and the new commit includes the renamed test LesionSizingToolkitCannyEdgeDetectionImageFilterTest2 and the header itkImageRegionIteratorWithIndex.h.
  • Compared the upstream commits to confirm the transition from the old test itkCannyEdgeDetectionImageFilterTest2 without an include to the new test with itkImageRegionIteratorWithIndex.h.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
Modules/Remote/LesionSizingToolkit.remote.cmake Updates the LesionSizingToolkit remote module GIT_TAG to a newer pinned commit; no issues found in the remote module declaration.

Reviews (1): Last reviewed commit: "COMP: Update LesionSizingToolkit to 29ae..." | Re-trigger Greptile

@hjmjohnson
hjmjohnson requested a review from dzenanz July 19, 2026 15:07
@hjmjohnson
hjmjohnson merged commit d2ed191 into InsightSoftwareConsortium:main Jul 20, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Remotes Issues affecting the Remote module type:Compiler Compiler support or related warnings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants