Fix: Align RMSE and log RMSE calculations with standard definitions#19
Open
Nickory wants to merge 1 commit into
Open
Fix: Align RMSE and log RMSE calculations with standard definitions#19Nickory wants to merge 1 commit into
Nickory wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi authors,
Thank you for releasing this excellent work and the highly readable codebase!
While studying the evaluation metrics, I noticed a minor mathematical detail regarding the
rmseandrmse_logcalculations. Currently, taking the square root before the mean effectively computes the Mean Absolute Error (MAE).This PR makes a slight adjustment by moving
.mean()insidetorch.sqrt(), which aligns the code strictly with the standard mathematical formulation of Root Mean Square Error (RMSE).Hope this small refinement is helpful to your amazing project. Thanks again for your great contributions to the community!