Release version 0.1.3.2

[randhirinsta]

• Security: Migration files on the destination site now use unguessable hashed filenames for stronger privacy.
• Improved: Each push migration automatically cleans up leftover artifact files at start for a cleaner destination site.

[claude]

Claude finished @randhirinsta's task —— View job

---

Pull Request Review Complete

Context loaded:

• CLAUDE.md (project guidelines)
• .claude/randhirinsta.claude (developer preferences)

Review Todo List:

• Load developer context and project guidelines
• Analyze changed files for architectural principles compliance
• Review security improvements and hashed filename implementation
• Check cleanup functionality for artifact files
• Assess code quality, performance, and best practices
• Verify backward compatibility
• Provide comprehensive feedback and recommendations

---

✅ Overall Assessment: EXCELLENT

This PR implements a critical security hardening feature with excellent engineering practices. The changes demonstrate strong adherence to architectural principles and security best practices.

🔒 Security Improvements

Critical Security Enhancement

• Hashed Filenames: Migration files now use unguessable hashed filenames instead of predictable ones
  • Old: db.sql, iwp-push-log.txt → New: db-{hash}.sql, iwp-push-log-{hash}.txt
  • Impact: Prevents unauthorized access to migration dumps via URL guessing on staging domains
  • Hash: 64-bit entropy (16 hex chars) from SHA-256 of migration key - cryptographically strong

Backward Compatibility

• Wire protocol unchanged (X-File-Relative-Path: db.sql) - older source plugins continue working
• Graceful fallback to legacy naming when no hash provided

🧹 Automatic Cleanup System

Self-Healing Architecture

• Proactive Cleanup: iwp_cleanup_stale_migration_files() runs at migration start
• Broad Pattern Matching: Catches both legacy and hashed filenames
• Race Condition Protection: 6-hour staleness threshold prevents interference with active migrations
• Comprehensive Coverage: Includes encrypted credential sidecars (migrate-push-db-*.txt)

🏗️ Architectural Excellence

✅ STRONG ADHERENCE TO CORE PRINCIPLES

1. Single Source of Truth (SSOT)

• iwp_get_migration_file_paths() - centralized filename management
• All components use same hash derivation logic
• Eliminates filename inconsistencies

2. DRY (Don't Repeat Yourself)

• iwp_get_migration_key_hash() - shared hash generation
• iwp_delete_migration_files() - reusable cleanup logic
• Consolidated glob patterns in clean_iwp_files_dir()

3. Separation of Concerns (SoC)

• Hash generation → iwp_get_migration_key_hash()
• Path management → iwp_get_migration_file_paths()
• Cleanup logic → iwp_cleanup_stale_migration_files()
• Each function has single, clear responsibility

4. Proper Abstraction

• Clean APIs with documented parameters
• Idempotent operations (safe to call multiple times)
• Host-specific considerations (suEXEC/suPHP permissions)

📋 Code Quality Assessment

✅ Strengths

• Excellent Documentation: Clear PHPDoc with security rationale
• Error Handling: Proper use of @unlink() for permission issues
• Performance: Efficient glob patterns, bounded cleanup operations
• Security: Hash timing attack protection via deterministic generation

✅ WordPress Standards Compliance

• Proper function existence checks (if ( ! function_exists() ))
• Correct escaping and validation patterns
• WordPress coding standards followed

🔧 Implementation Details

iwp-dest/index.php Changes

// Lines 28-32: Per-migration filename suffix generation
$migration_key_hash = iwp_get_migration_key_hash( $migrate_key );
$log_file_path = $root_dir_path . DIRECTORY_SEPARATOR . 'iwp-push-log-' . $migration_key_hash . '.txt';
$received_db_path = $root_dir_path . DIRECTORY_SEPARATOR . 'iwp-db-received-' . $migration_key_hash . '.sql';

// Lines 127-134: Secure db.sql handling
$file_save_path = $root_dir_path . DIRECTORY_SEPARATOR . 'db-' . $migration_key_hash . '.sql';

functions-pull-push.php Enhancements

• Hash Generation: 64-bit entropy from SHA-256
• Path Management: Centralized via iwp_get_migration_file_paths()
• Cleanup System: Comprehensive stale file removal

class-instawp-tools.php Improvements

• Updated clean_iwp_files_dir() with glob patterns
• Handles both legacy and hashed filenames
• Respects user's "Keep DB SQL File" setting

🚀 Performance & Reliability

• Bounded Operations: 6-hour staleness threshold prevents runaway cleanup
• Efficient Patterns: Single glob calls vs. individual file checks
• Memory Conscious: Processes files individually, not in bulk arrays
• Host Compatibility: Considers different PHP/web server configurations

🔍 Minor Observations

Suggestions for Future Enhancement

1. Monitoring: Consider logging cleanup statistics for operational visibility
2. Configuration: The 6-hour threshold could be configurable for extreme edge cases
3. Metrics: Track cleanup effectiveness in migration logs

Code Style Notes

• Excellent use of strict comparison (===, !==)
• Proper array casting with (array) glob()
• Good variable naming conventions

🎯 Recommendation: APPROVE

This is exemplary work that significantly enhances security while maintaining backward compatibility. The implementation demonstrates:

• Security First: Addresses real vulnerability (URL-guessable migration files)
• Operational Excellence: Self-healing cleanup system
• Engineering Quality: Clean abstractions, proper separation of concerns
• Production Ready: Comprehensive edge case handling

The PR is ready for merge with confidence.

---