Skip to content

fix(build): resolve TS2589 in server.ts and axios header type drift in media.ts #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kleintech wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Open

fix(build): resolve TS2589 in server.ts and axios header type drift in media.ts #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,10 @@ for (const tool of allTools) {
// const jsonSchema = zodToJsonSchema(z.object(tool.inputSchema.properties as z.ZodRawShape));
// const parsedSchema = z.any().optional().parse(jsonSchema);

const zodSchema = z.object(tool.inputSchema.properties as z.ZodRawShape);
server.tool(tool.name, zodSchema.shape, wrappedHandler)
const rawShape = tool.inputSchema.properties as z.ZodRawShape;
// Cast bypasses TS2589: server.tool's generic resolves ShapeOutput<Args>
// against the SDK's z3|z4 union schema type, exploding instantiation depth.
(server.tool as (name: string, schema: z.ZodRawShape, cb: typeof wrappedHandler) => unknown)(tool.name, rawShape, wrappedHandler);

}

Expand Down
3 changes: 2 additions & 1 deletion src/tools/media.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,8 @@ async function loadUploadFromUrl(sourceUrl: string, explicitTitle?: string): Pro
}

const response = await axios.get<ArrayBuffer>(sourceUrl, { responseType: 'arraybuffer' });
const mimeType = normalizeMimeType(response.headers['content-type']);
const contentTypeHeader = response.headers['content-type'];
const mimeType = normalizeMimeType(typeof contentTypeHeader === 'string' ? contentTypeHeader : undefined);
const originalFilename = deriveFilenameFromUrl(sourceUrl, mimeType);
const filename = buildUploadFilename(originalFilename, explicitTitle);

Expand Down