Repository navigation
Plan iCloud sync and add reader profile foundation - #15
Merged
Merged
Conversation
… & SavedWord.swift
…etupSheet.swift, & WordChip.swift
Persisted stores decoded whole arrays with try? decode([T].self), so one legacy or corrupt record dropped the entire array to [], and the next save overwrote the good persisted bytes with an empty array. Making profileID a required field on Bookmark/SavedWord turned every pre-profiles blob into exactly such a failure. Decode element-by-element via a FailableCodable wrapper so a bad record is skipped instead of failing the array, and refuse to overwrite a store whose non-empty bytes decoded to nothing. Legacy Bookmark/SavedWord blobs without profileID now decode to a sentinel and are rehomed onto the active profile on load rather than being orphaned. Adds LegacyDecode tests covering legacy-blob survival, mixed-array recovery, and the no-overwrite-on-total-corruption guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup (no users yet)
Since the app has no shipped users, this branch keeps the model clean rather than backward-compatible:
profileIDonBookmark/SavedWordis required (non-optional) with synthesizedCodablelastReadProgression/lastReadLocatorJSONfields fromBookactiveProfileis a pure read; default-profile setup runs once at launch to avoid mutating state during view updatesVerification