Repository navigation
feat(icloud): add private sync engine - #19
Merged
Merged
Conversation
# Conflicts: # Piperly/Services/BookStore.swift
Address the remaining #19 sync-correctness findings from the Opus review. - Reading progress no longer regresses on an untrusted device clock: a same-locator progression decrease is treated as clock skew and the higher progression is kept (LibraryConflictResolver + applyRemoteSave route through one resolver). A genuine locator change may still lower it. - Bound the deferred/quarantine/account-transition snapshot buckets and expire delete tombstones via SyncSnapshotMaintenance, pruned on every persist. - Add bounded persistent tombstones so an older cross-device save cannot resurrect a recently deleted record after the local delete is sent/cleared. - Make remote profile-delete replacement idempotent (keyed on "no profiles exist") and stop treating a failed replacement enqueue as an unresolved deletion, preventing duplicate default profiles on retry. - Update ADR 0002 reading-state rule to match the non-regression policy. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Manual Apple setup
iCloud.com.piperly.appCloudKit container in the Apple Developer portalStack
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.