Skip to content

feat(leadership): add watch-only clients - #24

Merged
serabi merged 22 commits into
feat/attach-existingfrom
feat/827-watch-only
Oct 21, 2026
Merged

serabi merged 22 commits into
feat/attach-existingfrom
feat/827-watch-only

Conversation

@serabi

@serabi serabi commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Why

Add watch-only terminal attachments and explicit size takeover for Interactive-Buffoonery/awesomux#827, following ADR-0036. This is stacked on #22 and preserves existing-only attach.

What's Included

  • Add watch-only connections that cannot send input, resize the terminal or take over.
  • Add explicit takeover and terminal size notifications.
  • Keep input and resize operations in order; preserve terminal size when clients attach or disconnect.
  • Fix keyboard, terminal-query, pixel-size and queue handling bugs.

Validation

Build, socket tests, 21 regression scenarios, Zig tests and 52 BATS tests passed. Independent review found no new actionable defects after fixes.

Native app and real-TUI acceptance remain incomplete. Compatibility with older servers is tested with a simulated socket server.

Risk Notes

Two behavior issues remain unresolved: a client that does not control terminal sizing can lose a standalone Escape keypress, and a new pane can ignore size corrections before its first input. This PR remains draft until those issues and native verification are resolved.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

serabi added 22 commits October 20, 2026 19:13
Port the reply classifier and regression case from upstream commit
54b212d without unrelated changes.
Add permanently restricted typed attachments and explicit takeover while
preserving frozen legacy tags. Serialize size claims and user batches
through owned PTY operations and invalidate stale replies on epoch changes.

Keep legacy attach's mixed-stdin limitation explicit. Add socket regression
coverage and update retained-grid reattach expectations.

Refs: Interactive-Buffoonery/awesomux#827
Bound legacy resize rejection without unwinding the daemon. Track
uninterrupted ownership separately from reply epochs so same-leader
input preserves queued resize barriers. Capture pixel preferences per
operation and preserve kernel pixels when no replacement is supplied.
@serabi
serabi marked this pull request as ready for review October 21, 2026 00:56
@serabi
serabi merged commit 31d4140 into feat/attach-existing Oct 21, 2026
1 check passed
serabi added a commit that referenced this pull request Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant