Repository navigation
feat(leadership): add watch-only clients - #24
Merged
Merged
Conversation
Port the reply classifier and regression case from upstream commit 54b212d without unrelated changes.
Add permanently restricted typed attachments and explicit takeover while preserving frozen legacy tags. Serialize size claims and user batches through owned PTY operations and invalidate stale replies on epoch changes. Keep legacy attach's mixed-stdin limitation explicit. Add socket regression coverage and update retained-grid reattach expectations. Refs: Interactive-Buffoonery/awesomux#827
Bound legacy resize rejection without unwinding the daemon. Track uninterrupted ownership separately from reply epochs so same-leader input preserves queued resize barriers. Capture pixel preferences per operation and preserve kernel pixels when no replacement is supplied.
1 of 2 tasks
serabi
marked this pull request as ready for review
October 21, 2026 00:56
serabi
added a commit
that referenced
this pull request
Nov 7, 2026
feat(leadership): add watch-only clients
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Add watch-only terminal attachments and explicit size takeover for Interactive-Buffoonery/awesomux#827, following ADR-0036. This is stacked on #22 and preserves existing-only attach.
What's Included
Validation
Build, socket tests, 21 regression scenarios, Zig tests and 52 BATS tests passed. Independent review found no new actionable defects after fixes.
Native app and real-TUI acceptance remain incomplete. Compatibility with older servers is tested with a simulated socket server.
Risk Notes
Two behavior issues remain unresolved: a client that does not control terminal sizing can lose a standalone Escape keypress, and a new pane can ignore size corrections before its first input. This PR remains draft until those issues and native verification are resolved.
Need help on this PR? Tag
@codesmith-botwith what you need.