Repository navigation
fix(session): preserve unresponsive session sockets - #28
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Merged
4 tasks done
This was referenced Nov 7, 2026
serabi
force-pushed
the
feat/attach-existing
branch
from
November 7, 2026 04:46
0f1ac1f to
250dad4
Compare
serabi
force-pushed
the
fix/preserve-unresponsive-sessions
branch
from
November 7, 2026 04:48
ffa16fa to
6c6ab41
Compare
This comment has been minimized.
This comment has been minimized.
External contributor checklistThanks for contributing. A maintainer will handle the trusted checks and final merge.
|
serabi
force-pushed
the
fix/preserve-unresponsive-sessions
branch
from
November 7, 2026 05:15
6c6ab41 to
3f06807
Compare
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Keep a live session when its daemon is slow or sends an incompatible reply. A failed probe must not remove a socket that may still lead to running work.
What's Included
test/reconnect.pyto check healthy attach, paused and incompatible daemons, stale socket recovery, and fixture cleanup.UI / UX
Not applicable. This changes backend session recovery.
Notes
Models: Codex
Merge risk: medium. This changes which failed probes allow session recovery. Recovery: revert for future attempts; a revert cannot restore work ended by an earlier recovery attempt.
Current-head check:
git diff --checkpasses. Changes since6c6ab41, including inherited changes, are documentation only; runtime and test source are unchanged. At6c6ab41, macOS Zig 0.16 formatting, unit tests, build, 3 reattach cases, and 5 reconnect checks passed with clean fixture teardown. These are prior-head results. Thetest/reconnect.pyreview thread remains open for Sarah; the fork-fit review did not find a demonstrated blocker. Native app presentation and VoiceOver are not covered by the backend regression.Keep
awesomux-pin-ffa16faandawesomux-pin-cc24771; awesoMux refs still use those old revisions. Merge with a merge commit and keep the branch.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.fix(session): preserve unresponsive session sockets
Summary
ensureSessionprobe handling so a session socket is recreated only when the probe fails witherror.ConnectionRefused.test/reconnect.py, an end-to-end regression test covering healthy attach, timeout preservation, resumed attach, incompatible-backend preservation, and refused stale-socket recovery.Security impact
Performance impact
Code quality
test/reconnect.pyis large and contains platform-specific process-birth detection plus custom PTY/socket orchestration. It is purposeful regression coverage, but if similar helpers already exist, extracting shared test utilities would reduce duplication.Testing
python3 test/reconnect.py /path/to/zmxfor the isolated reconnect regression.