Skip to content

ci(attach): run real-daemon replay regression - #31

Merged
serabi merged 1 commit into
mainfrom
ci/attach-regression
Nov 7, 2026
Merged

serabi merged 1 commit into
mainfrom
ci/attach-regression

Conversation

@serabi

@serabi serabi commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Why

Catch attach replay regressions in hosted Linux CI before they reach main.

What's Included

  • Build zmx and the terminal replay helper, then run all attach regression cases in CI.
  • Update the contributor guide to describe the checks CI now runs.

UI / UX

Not applicable. This changes CI and contributor guidance.

Notes

Models: GPT-6.1 Sol

Merge risk: low. The two-file change passes local workflow checks and hosted Linux CI, including all 96 attach cases. Recovery: revert this workflow change; completed runs keep their results.

Local checks pass: git diff --check, actionlint, and all 6 PR automation tests. Before this two-file change, a clean macOS checkout of main b8eb0f6 passed Zig 0.16 formatting, unit tests, build, replay tests, and all 96 attach cases. Hosted main CI also passed. Hosted Linux CI run 42342847334 passed at 2f2e47e, including the new Attach regression step with 96/96 cases.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary

CI now runs the real-daemon attach/replay regression that previously existed only as a manual, documented step. The attach regression is promoted from "run this locally when you touch attach code" to a blocking CI check on Linux, and CONTRIBUTING.md is updated to match the new CI reality.

Changes

.github/workflows/ci.yml

  • Adds an Attach regression step to the Linux job:
    zig build && zig build test-replay && python3 test/attach_scrollback.py zig-out/bin/zmx
  • This exercises the actual zmx binary against test/attach_scrollback.py, so scrollback/attach behavior regressions are caught in CI rather than only during manual verification.

CONTRIBUTING.md

  • Replaces the stale "After PR fix(attach): restore full terminal state on reattach #29 merges, add this to CI" note with the post-merge state: CI now covers Linux formatting, unit tests, terminal replay tests, PR automation tests, and the real-daemon attach regression.
  • Retains the explicit local command for contributors working on attach changes, and keeps the existing caveat that macOS and awesoMux behavior remain unproven by CI.

Security Impact

None. No production code, input handling, or trust boundaries are touched. The only new execution is a CI step invoking the project's own test binary and a repo-local Python script.

Performance Impact

  • Runtime: Adds one build + replay test + Python regression run to every Linux CI job, increasing job wall-clock time. This is the intended cost of gating attach regressions.
  • Product: No change to runtime performance, binary size, or startup behavior.

Review Callouts

  • Redundant build: The new step re-runs zig build immediately after the Unit tests step (zig build test), which already compiles the artifacts test-replay and the Python harness consume. Dropping the leading zig build would shorten CI without changing coverage — worth confirming whether it was added deliberately for the zmx binary specifically.
  • Duplicated command: The exact same command now lives in both ci.yml and CONTRIBUTING.md. Extracting it into a single script (e.g. test/attach_regression.sh) would keep the docs and CI from drifting, and gives contributors one entry point to run.
  • Docs update is accurate and correctly scoped — it removes the now-obsolete "after PR fix(attach): restore full terminal state on reattach #29 merges" instruction rather than leaving contradictory guidance.

Verification

zig build test, then the new CI step locally: zig build && zig build test-replay && python3 test/attach_scrollback.py zig-out/bin/zmx.

@kody-ai

kody-ai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

Access your configuration settings here.

​

@github-actions github-actions Bot added the size:S 10-29 effective changed lines. label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown

External contributor checklist

Thanks for contributing. A maintainer will handle the trusted checks and final merge.

  • A maintainer has reviewed the change.
  • The PR description follows the template.
  • Visible changes include screenshots or a clear not-applicable explanation.
  • A maintainer confirmed no untrusted fork code was run with repository secrets.

@serabi
serabi merged commit 8b8bd21 into main Nov 7, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 effective changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant