fix: prevent infinite layout loop in CatalogHeroView - #10
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an app hang issue (OPENNOW-MAC-22) caused by an infinite layout loop within
CatalogHeroViewinCatalogView.swift.Root Cause:
The
GeometryReader'sonChange(of: proxy.size.width)handler was updatingcontainerWidth, which in turn adjusted theCatalogHeroView's height. When this view is inside aScrollView, changes in its height can cause the macOS vertical scrollbar to toggle on or off. This scrollbar toggle changes the available width by approximately 15pt, which was enough to re-trigger theonChangehandler, creating a continuous feedback loop and hanging the app during the SwiftUI layout pass.Solution:
Introduced a threshold check in the
onChangehandler forproxy.size.width. ThecontainerWidthwill now only be updated if the absolute difference between the currentcontainerWidthand the newwidthis greater than 20 points. This effectively filters out the minor width fluctuations caused by the scrollbar appearing or disappearing, breaking the infinite loop while still allowing legitimate window resizing to function correctly.Fixes OPENNOW-MAC-22