fix: prevent app hang from synchronous font loading - #11
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an app hang (at least 2000 ms) caused by repeated synchronous loading and parsing of WOFF2 fonts on the main thread. Previously,
OpenNOWNVIDIAFont.loadDescriptor(named:)was called on every font access, leading to performance issues during SwiftUI view layouts.The fix introduces
static letproperties forCTFontDescriptorinstances withinOpenNOWNVIDIAFont. This ensures that each font weight's descriptor is loaded and parsed from disk only once, on its first access. Subsequent requests for the same font weight will retrieve the cached descriptor, eliminating redundant disk I/O and main thread blocking.Fixes OPENNOW-MAC-21