fix: prevent app hang during image scrim color calculation - #12
Open
sentry[bot] wants to merge 1 commit into
Open
fix: prevent app hang during image scrim color calculation#12sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an app hang issue (OPENNOW-MAC-2Q) caused by synchronous, CPU-intensive image processing on the main thread.
Root Cause:
The
loadImage()function, marked@MainActor, was callingCatalogHeroImageMetadata.scrimColor(from:)directly. This function, in turn, performed blocking operations likeCGImageSourceCreateWithData,CGImageSourceCreateThumbnailAtIndex, and JSON decoding on the main thread. For larger images, this work could exceed 2000 ms, leading to an app hang.Solution:
CatalogHeroImageMetadata.scrimColor(from:): Modified this function to beasyncandnonisolated. The heavy image processing and JSON decoding logic within it is now wrapped inawait Task.detached(priority: .userInitiated) { ... }.value. This ensures that all CPU-bound work is executed on a background thread, freeing up the main actor.loadImage()call site: The call toCatalogHeroImageMetadata.scrimColor(from:)inloadImage()nowawaits theasyncversion. This allows the main thread to yield control while the background task completes, preventing UI unresponsiveness. Aguard !Task.isCancelledcheck was added after theawaitto handle potential task cancellations gracefully.Impact:
This change significantly improves UI responsiveness when loading catalog hero images by offloading heavy image metadata extraction from the main thread, thereby preventing app hangs.
Fixes OPENNOW-MAC-2Q