fix: cache NVIDIA font descriptors to prevent app hang - #8
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an app hang (2000ms+) identified as OPENNOW-MAC-1Y. The root cause was the synchronous loading and conversion of WOFF2 font files on the main thread during every layout pass within
OpenNOWNVIDIAFont.loadDescriptor.The fix introduces static caching for the
CTFontDescriptorobjects. Now, the font files are read from disk and converted only once per application lifetime, and subsequent requests retrieve the cached descriptor. This eliminates redundant disk I/O and CPU-intensive font conversion on the main thread, resolving the app hang.Fixes OPENNOW-MAC-1Y