WIP: Switch to cardano-config#6608
Open
jasagredo wants to merge 3 commits into
Open
Conversation
…rdano-config These tools parsed the node configuration file with the node's own parseNodeConfigurationFP / FromJSON PartialNodeConfiguration. Route them through cardano-config instead, via the new Cardano.Node.Configuration.Adapter helper (nodeConfigurationFromFile), matching the cardano-node switch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
With cardano-node, the chairman, tx-generator and cardano-testnet all
routing through cardano-config, nothing parses the node configuration
file via the node's own machinery anymore. Drop:
* instance FromJSON PartialNodeConfiguration (and all its helpers),
* instance AdjustFilePaths PartialNodeConfiguration (path resolution
is now done in the Adapter),
* parseNodeConfigurationFP,
together with the imports they pulled in (including the yaml package
dependency) and the two POM tests that exercised the JSON decoding. The
PartialNodeConfiguration / NodeConfiguration model and makeNodeConfiguration
are kept: they remain the node's resolved configuration type and the target
of Cardano.Node.Configuration.Adapter.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jasagredo
force-pushed
the
js/cardano-config
branch
from
22f7aad to
23c26d3
Compare
jasagredo
force-pushed
the
js/cardano-config
branch
from
23c26d3 to
1aab680
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add your description here, if it fixes a particular issue please provide a
link
to the issue.
Checklist
See Running tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.