refactor: remove legacy builders directory and update URLs to Interse…#46
Merged
Conversation
…ctMBO BREAKING CHANGE: Remove old src/builders/ directory in favor of new SDK architecture - Delete legacy builders directory (TxBuilder, CertificateBuilder, etc.) - These have been superseded by the new SDK builders in src/sdk/builders/ - The old builders were causing duplicate documentation generation - Update Evolution package.json URLs to IntersectMBO organization - Update docgen.json projectHomepage to IntersectMBO This is the proper fix - removing duplicate/legacy code rather than excluding it. The new SDK architecture in src/sdk/ contains the modern, refactored builders.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the legacy src/builders/ directory in favor of the new SDK architecture located in src/sdk/builders/. The legacy builders were causing duplicate documentation generation and have been superseded by the refactored SDK implementation. Additionally, repository URLs are updated from the no-witness-labs organization to IntersectMBO.
Key Changes
- Removed entire legacy
src/builders/directory including all builder classes (TxBuilder, CertificateBuilder, InputBuilder, etc.) - Updated package.json URLs to point to IntersectMBO organization
- Updated docgen.json projectHomepage to IntersectMBO organization
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/evolution/src/builders/utils/index.ts | Removed export statement for MinAda utility |
| packages/evolution/src/builders/utils/MinAda.ts | Deleted MinAda calculation utility (178 lines) |
| packages/evolution/src/builders/index.ts | Removed all builder module exports |
| packages/evolution/src/builders/WitnessBuilder.ts | Deleted witness tracking and script witness builders |
| packages/evolution/src/builders/WithdrawalBuilder.ts | Deleted withdrawal builder implementation |
| packages/evolution/src/builders/VoteBuilder.ts | Deleted governance vote builder |
| packages/evolution/src/builders/TxBuilder.ts | Deleted main transaction builder (986 lines) |
| packages/evolution/src/builders/RedeemerBuilder.ts | Deleted redeemer set builder for Plutus scripts |
| packages/evolution/src/builders/ProposalBuilder.ts | Deleted governance proposal builder |
| packages/evolution/src/builders/OutputBuilder.ts | Deleted transaction output builder |
| packages/evolution/src/builders/MintBuilder.ts | Deleted token minting builder |
| packages/evolution/src/builders/InputBuilder.ts | Deleted transaction input builder |
| packages/evolution/src/builders/CertificateBuilder.ts | Deleted certificate builder for stake operations |
| packages/evolution/package.json | Updated repository URLs to IntersectMBO organization |
| packages/evolution/docgen.json | Updated project homepage to IntersectMBO organization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove old src/builders/ directory in favor of new SDK architecture
This is the proper fix - removing duplicate/legacy code rather than excluding it. The new SDK architecture in src/sdk/ contains the modern, refactored builders.