Skip to content

(feat#3745): display authors for Live Voting Governance Actions#3787

Merged
bosko-m merged 1 commit into
developfrom
3745-display-authors-for-live-voting-governance-actions
Jun 13, 2025
Merged

(feat#3745): display authors for Live Voting Governance Actions#3787
bosko-m merged 1 commit into
developfrom
3745-display-authors-for-live-voting-governance-actions

Conversation

@Ciabas
Copy link
Copy Markdown
Contributor

@Ciabas Ciabas commented Jun 13, 2025

List of changes

  • Add authors for Live Voting Governance Actions

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works
image image image image image

Currently not many gov_action_proposal contains any authors.

SELECT
    gov_action_proposal.id,
    off_chain_vote_author.name AS author_name,
    off_chain_vote_author.witness_algorithm,
    off_chain_vote_author.public_key,
    off_chain_vote_author.signature
FROM
    gov_action_proposal
    LEFT JOIN tx AS creator_tx ON creator_tx.id = gov_action_proposal.tx_id
    LEFT JOIN voting_anchor ON voting_anchor.id = gov_action_proposal.voting_anchor_id
    LEFT JOIN off_chain_vote_data ON off_chain_vote_data.voting_anchor_id = voting_anchor.id
    LEFT JOIN off_chain_vote_author ON off_chain_vote_author.off_chain_vote_data_id = off_chain_vote_data.id

@Ciabas Ciabas requested a review from bosko-m June 13, 2025 09:41
@Ciabas Ciabas requested review from MSzalowski and Ryun1 as code owners June 13, 2025 09:41
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@Ciabas Ciabas force-pushed the 3745-display-authors-for-live-voting-governance-actions branch from c7e6bb6 to 8188beb Compare June 13, 2025 13:47
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@Ciabas Ciabas self-assigned this Jun 13, 2025
@bosko-m bosko-m merged commit 34ebe49 into develop Jun 13, 2025
10 checks passed
@bosko-m bosko-m deleted the 3745-display-authors-for-live-voting-governance-actions branch June 13, 2025 14:26
@github-actions
Copy link
Copy Markdown
Contributor

@Ciabas
This PR is in the tag: develop-34ebe49c9dd8cbe9fdc80e1afc7f0d4a57bb5075 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

@Ciabas
This PR is in the tag: develop-34ebe49c9dd8cbe9fdc80e1afc7f0d4a57bb5075 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

@Ciabas
This PR is in the tag: develop-34ebe49c9dd8cbe9fdc80e1afc7f0d4a57bb5075 , for govtool-frontend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants