Skip to content

Update get-network-total-stake.sql#4033

Closed
bosko-m wants to merge 1 commit into
developfrom
4032-fix-double-counting-always-no-confidence
Closed

Update get-network-total-stake.sql#4033
bosko-m wants to merge 1 commit into
developfrom
4032-fix-double-counting-always-no-confidence

Conversation

@bosko-m
Copy link
Copy Markdown
Contributor

@bosko-m bosko-m commented Aug 14, 2025

List of changes

  • Add / Fix / Change / Remove

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

Signed-off-by: bosko-m <88723596+bosko-m@users.noreply.github.com>
@bosko-m bosko-m requested a review from MSzalowski as a code owner August 14, 2025 11:37
ORDER BY epoch_no DESC LIMIT 1), 0) AS amount
)
SELECT
COALESCE(TotalStakeControlledByActiveDReps.total, 0) + COALESCE(AlwaysNoConfidenceVotingPower.amount, 0) AS total_stake_controlled_by_active_dreps,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the double counting?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assumption is that the TotalStakeControlledByActiveDReps already includes it as its coming from drep_distr covering all drep hashes already

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@bosko-m bosko-m closed this Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants