Skip to content

Add memory models for valueData and unValueData #7520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ana-pantilie wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add memory models for valueData and unValueData #7520

ana-pantilie wants to merge 4 commits into from

Conversation

@ana-pantilie
Copy link
Contributor

@ana-pantilie ana-pantilie commented Jan 13, 2026 •
edited
Loading

@ana-pantilie ana-pantilie marked this pull request as ready for review January 13, 2026 21:11
@ana-pantilie ana-pantilie requested review from kwxm and zliu41 January 13, 2026 21:11
@kwxm
Copy link
Contributor

kwxm commented Jan 14, 2026

I think the easiest way to deal with this would just be to extract the parts that I need and copy them into my branch.

zliu41
zliu41 reviewed Jan 14, 2026
View reviewed changes
plutus-core/cost-model/create-cost-model/BuiltinMemoryModels.hs
such situations. To ensure non-negative memory costs, we further overapproximate the formula
to remove the negative intercept:
Memory = 21*(n/2) + 12 = 10.5*n + 12 --approx--> 11*n + 12
Copy link
Member

@zliu41 zliu41 Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the problem is negative intercept, why not just make intercept 0?

Copy link
Contributor Author

@ana-pantilie ana-pantilie Jan 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the intercept is 0 then for an empty result the memory will be 0 which I don't think we want. Also, I don't really like the way I had to approximate things here, ideally we'd have a way to differentiate between the two cases (empty and non-empty) but I don't think that's possible with the current costing framework.

@kwxm
Copy link
Contributor

kwxm commented Jan 14, 2026

I think the easiest way to deal with this would just be to extract the parts that I need and copy them into my branch.

I've done this now: other things had changed in plutus-ledger-api and just adding the changes that I needed (the numbers in the JSON files and the models and the explanatory Note in BuiltinMemoryModels.hs) saved me from some conflicts.

@ana-pantilie
Copy link
Contributor Author

ana-pantilie commented Jan 14, 2026

@kwxm should I just close this PR then?

@kwxm kwxm mentioned this pull request Jan 14, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zliu41 zliu41 zliu41 left review comments

@kwxm kwxm Awaiting requested review from kwxm

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ana-pantilie @kwxm @zliu41