added copyListWithRandomPointer #6
Conversation
| @@ -0,0 +1,60 @@ | |||
| const copyRandomList = (head) => { | |||
| let copies = new Map(); | |||
There was a problem hiding this comment.
Add a comment explaining why you used a Map instead of an object (this is an object const x = {};).
I believe the reason is because you want to use an instance of the Node class as your key (JS objects only allow strings as the keys).
| let copy = new Node(current.val, current.next, null); | ||
| copy.next = current.next; | ||
| current.next = copy; | ||
| current = current.next; |
There was a problem hiding this comment.
You can do current = current.next.next;, no need for this to be 2 lines.
| }; | ||
|
|
||
| /* | ||
| O(1) space solution. Honestly, don't even worry about knowing how to do this. |
There was a problem hiding this comment.
I agree that this seems like something you shouldn't have to know how to do. But, on my Amazon interviews, I got this question and the interviewer definitely seemed to expect me to get the O(1) solution (I finished the O(n) one pretty fast and she spent quite a long time watching me struggled to get O(1)). I think we should still tell them to not worry about knowing how to do this, but what do you think?
| O(1) space solution. Honestly, don't even worry about knowing how to do this. | ||
| */ | ||
| const copyRandomList = (head) => { | ||
| if (!head) return null; |
There was a problem hiding this comment.
Add a comment or some comments explaining how this works, I think it's not very intuitive.
| const copyRandomList = (head) => { | ||
| if (!head) return null; | ||
|
|
||
| let current = head; |
There was a problem hiding this comment.
Every variable in this function can be turned into a const instead of let. const means that you cannot reassign variables e.g.
const x = {};
x = {h: 5};
That is bad^
But this is fine:
const x = {};
x.h = 5;
Change this in the O(n) solution too
| } | ||
|
|
||
| current = head; | ||
| let copy = head.next; |
There was a problem hiding this comment.
Name this better. Maybe like headOfCopy.
Shreshth3
force-pushed
the
main
branch
2 times, most recently
from
e286181 to
d69c4be
Compare
No description provided.