Repository navigation
Mesh: keep pair.sync per-peer when another device is selected - #195
Open
hughesyadaddy wants to merge 2 commits into
Open
hughesyadaddy wants to merge 2 commits into
hughesyadaddy wants to merge 2 commits into
Conversation
In multi-device mode the hub facade only delivers messages from the selected peer, so pair.sync updates were dropped and pairSync entries drifted. Listen on hub.bus for pair.sync from other peers, merge into settings.pairSync only, and send saved values on bus welcome when hosting a guest that is not selected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #193
In Multi-device (mesh) mode,
PairSyncuses the hub facade, which only delivers messages from the currently selected peer (hub._fromDeviceroutes toselectedIdonly). Switch changes and the host'spair.sync {all}on connect were dropped for other connected peers, sosettings.pairSync[peerId]drifted apart.Change: In mesh
main.json Mac, Windows, and Linux, passhub.busintoPairSync. Listen forpair.syncon the bus from non-selected peers and merge into that peer's saved entry only (live global switches untouched). When hosting a guest that is not selected, send that peer's savedallon buswelcome. The selected peer still uses the facade, so nothing is handled twice.Tests:
shared/test/pairsync.js: stash while another device is selected, bus welcomeallto a non-selected guest, facade vs bus for the selected peer. Existing two-device tests unchanged (node shared/test/pairsync.jspasses).