Skip to content

Fix Mac screen capture source and constraints - #199

Draft
alexfoxtm wants to merge 1 commit into
InukaAsith:mainfrom
alexfoxtm:fix/mac-screen-capture-constraints
Draft

alexfoxtm wants to merge 1 commit into
InukaAsith:mainfrom
alexfoxtm:fix/mac-screen-capture-constraints

Conversation

@alexfoxtm

Copy link
Copy Markdown

Fixes: #198

What this changes:

The Mac calculates the requested capture source, output dimensions, and audio mode, but an inline comment accidentally omits them from the capture window's start message. Pass those values so capture can use the selected display and configured resolution and audio.

How I tested it:

  • node --test mac/test/stream-capture.js exercises the real Stream restart path with a stubbed Electron capture window. It verifies a selected 5K display is passed as 1920×1080 with the requested audio; the test fails against the base revision.
  • node --check mac/stream.js and git diff --check pass.
  • A local pre-fix test with a Galaxy and 5K display encountered H.264 initialization failures. The corrected build has not yet been verified end-to-end with Screen Recording permission, so this is a draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant