Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #200
What this changes:
On the Mac General page, show Allow for missing Screen Recording, Accessibility, and Input Monitoring permissions and use the existing permission request path. Once allowed, Open continues to open System Settings. Other permission rows retain their existing Open behavior.
How I tested it:
node shared/test/i18n-mac-general.jsverifies that a missing Screen Recording permission requests access and an allowed permission opens Settings, in English and Chinese.node shared/test/page-scripts.js,node --check mac/ui-general.js, andgit diff --checkpass.