BRD-1225: stop dropping products and variants with an empty SKU

src/Adapters/PrestaShopAdapter.php

@@ -58,7 +58,7 @@ private function transformProduct(array $product): array
     {
         $result = [
             'id' => $this->getRequiredField($product, 'remoteId'),
-            'sku' => $this->getRequiredField($product, 'sku'),
+            'sku' => (string) ($product['sku'] ?? ''),
             'price' => $this->getRequiredField($product, 'price'),
             'basePrice' => $this->getRequiredField($product, 'basePrice'),
             'priceTaxExcluded' => $this->getRequiredField($product, 'priceTaxExcluded'),

src/Adapters/PrestaShopAdapterV2.php

@@ -81,7 +81,7 @@ public function transform(array $prestaShopData): array
     public function transformProduct(array $product): Product
     {
         $id = $this->getRequiredField($product, 'remoteId');
-        $sku = $this->getRequiredField($product, 'sku');
+        $sku = (string) ($product['sku'] ?? '');
 
         $pricing = new ProductPricing(
             $this->extractPrice($product, 'price'),
@@ -180,9 +180,6 @@ public function transformVariant(array $variant, string $locale): ProductVariant
         }
 
         $sku = (string) ($variant['sku'] ?? '');
-        if ($sku === '') {
-            throw new ValidationException("Variant 'sku' is required");
-        }
 
         $pricing = new ProductPricing(
             $this->extractPrice($variant, 'price'),

src/Adapters/README.md

@@ -75,7 +75,7 @@ $result = $adapter->transform($prestaShopData);
 | PrestaShop Field       | BradSearch Field                 | Notes                   |
 | ---------------------- | -------------------------------- | ----------------------- |
 | `remoteId`             | `id`                             | Required                |
-| `sku`                  | `sku`                            | Required                |
+| `sku`                  | `sku`                            | Optional, `''` if none  |
 | `localizedNames`       | `name` (+ locale suffixes)       | Multi-locale support    |
 | `brand.localizedNames` | `brand` (+ locale suffixes)      | Multi-locale support    |
 | `productUrl`           | `productUrl` (+ locale suffixes) | Multi-locale support    |
@@ -135,7 +135,7 @@ PrestaShop variants are transformed to match BradSearch requirements:
 
 The adapter validates input data and throws `ValidationException` for:
 
-- Missing required fields (`remoteId`, `sku`)
+- Missing required fields (`remoteId`)
 - Invalid data structure
 - Missing product array
 

src/V2/ValueObjects/BulkOperations/Product.php

@@ -36,7 +36,6 @@ public function __construct(
         public array $additionalFields = []
     ) {
         $this->validateId($id);
-        $this->validateSku($sku);
     }
 
     /**
@@ -239,18 +238,4 @@ private function validateId(string $id): void
             );
         }
     }
-
-    /**
-     * @throws InvalidArgumentException
-     */
-    private function validateSku(string $sku): void
-    {
-        if (trim($sku) === '') {
-            throw new InvalidArgumentException(
-                'The product SKU cannot be empty.',
-                'sku',
-                $sku
-            );
-        }
-    }
 }

src/V2/ValueObjects/BulkOperations/ProductBuilder.php

@@ -17,7 +17,7 @@
 final class ProductBuilder
 {
     private ?string $id = null;
-    private ?string $sku = null;
+    private string $sku = '';
     private ?ProductPricing $pricing = null;
     private ?ImageUrl $imageUrl = null;
     private ?bool $inStock = null;
@@ -149,14 +149,6 @@ public function build(): Product
             );
         }
 
-        if ($this->sku === null) {
-            throw new InvalidArgumentException(
-                'Product SKU is required.',
-                'sku',
-                null
-            );
-        }
-
         if ($this->pricing === null) {
             throw new InvalidArgumentException(
                 'Product pricing is required.',
@@ -190,7 +182,7 @@ public function build(): Product
     public function reset(): self
     {
         $this->id = null;
-        $this->sku = null;
+        $this->sku = '';
         $this->pricing = null;
         $this->imageUrl = null;
         $this->inStock = null;

src/V2/ValueObjects/BulkOperations/ProductVariant.php

@@ -34,7 +34,6 @@ public function __construct(
         public array $attrs = []
     ) {
         $this->validateId($id);
-        $this->validateSku($sku);
         $this->validateProductUrl($productUrl);
     }
 
@@ -173,20 +172,6 @@ private function validateId(string $id): void
         }
     }
 
-    /**
-     * @throws InvalidArgumentException
-     */
-    private function validateSku(string $sku): void
-    {
-        if (trim($sku) === '') {
-            throw new InvalidArgumentException(
-                'The variant SKU cannot be empty.',
-                'sku',
-                $sku
-            );
-        }
-    }
-
     /**
      * @throws InvalidArgumentException
      */

tests/Adapters/PrestaShopAdapterTest.php

@@ -456,20 +456,79 @@ public function testTransformProductWithMissingSku(): void
             'products' => [
                 [
                     'remoteId' => '1807',
-                    // Missing sku
+                    'price' => '99.99',
+                    'basePrice' => '99.99',
+                    'priceTaxExcluded' => '82.64',
+                    'basePriceTaxExcluded' => '82.64',
                     'localizedNames' => [
                         'en-US' => 'Test Product'
-                    ]
+                    ],
+                    'categories' => [],
+                    'variants' => []
                 ]
             ]
         ];
 
         $result = $this->adapter->transform($prestaShopData);
 
-        $this->assertCount(0, $result['products']);
-        $this->assertCount(1, $result['errors']);
-        $this->assertEquals('transformation_error', $result['errors'][0]['type']);
-        $this->assertEquals("Required field 'sku' is missing from PrestaShop data", $result['errors'][0]['message']);
+        $this->assertCount(0, $result['errors']);
+        $product = $this->getProductFromResult($result);
+        $this->assertEquals('1807', $product['id']);
+        $this->assertSame('', $product['sku']);
+    }
+
+    public function testTransformProductWithNullSku(): void
+    {
+        $prestaShopData = [
+            'products' => [
+                [
+                    'remoteId' => '1807',
+                    'sku' => null,
+                    'price' => '99.99',
+                    'basePrice' => '99.99',
+                    'priceTaxExcluded' => '82.64',
+                    'basePriceTaxExcluded' => '82.64',
+                    'localizedNames' => [
+                        'en-US' => 'Test Product'
+                    ],
+                    'categories' => [],
+                    'variants' => []
+                ]
+            ]
+        ];
+
+        $result = $this->adapter->transform($prestaShopData);
+
+        $this->assertCount(0, $result['errors']);
+        $product = $this->getProductFromResult($result);
+        $this->assertSame('', $product['sku']);
+    }
+
+    public function testTransformProductWithEmptySku(): void
+    {
+        $prestaShopData = [
+            'products' => [
+                [
+                    'remoteId' => '1807',
+                    'sku' => '',
+                    'price' => '99.99',
+                    'basePrice' => '99.99',
+                    'priceTaxExcluded' => '82.64',
+                    'basePriceTaxExcluded' => '82.64',
+                    'localizedNames' => [
+                        'en-US' => 'Test Product'
+                    ],
+                    'categories' => [],
+                    'variants' => []
+                ]
+            ]
+        ];
+
+        $result = $this->adapter->transform($prestaShopData);
+
+        $this->assertCount(0, $result['errors']);
+        $product = $this->getProductFromResult($result);
+        $this->assertSame('', $product['sku']);
     }
 
     public function testTransformVariantWithoutRemoteId(): void

tests/Adapters/PrestaShopAdapterV2Test.php

@@ -446,6 +446,63 @@ public function testTransformVariantMissingRemoteId(): void
         $this->adapter->transformVariant($variant, 'en-US');
     }
 
+    public function testTransformProductWithNullSku(): void
+    {
+        $product = $this->getMinimalProductData('1807', 'SKU-123');
+        $product['sku'] = null;
+
+        $result = $this->adapter->transformProduct($product);
+
+        $this->assertEquals('1807', $result->id);
+        $this->assertSame('', $result->sku);
+        $this->assertSame('', $result->jsonSerialize()['sku']);
+    }
+
+    public function testTransformProductWithEmptySku(): void
+    {
+        $product = $this->getMinimalProductData('1807', '');
+
+        $result = $this->adapter->transformProduct($product);
+
+        $this->assertEquals('1807', $result->id);
+        $this->assertSame('', $result->sku);
+        $this->assertSame('', $result->jsonSerialize()['sku']);
+    }
+
+    public function testTransformProductWithMissingSku(): void
+    {
+        $product = $this->getMinimalProductData('1807', 'SKU-123');
+        unset($product['sku']);
+
+        $result = $this->adapter->transform(['products' => [$product]]);
+
+        $this->assertCount(0, $result['errors']);
+        $this->assertCount(1, $result['products']);
+        $this->assertSame('', $result['products'][0]->sku);
+    }
+
+    public function testTransformVariantWithEmptySku(): void
+    {
+        $variant = $this->getMinimalVariantData();
+        $variant['sku'] = '';
+
+        $result = $this->adapter->transformVariant($variant, 'en-US');
+
+        $this->assertEquals('12345', $result->id);
+        $this->assertSame('', $result->sku);
+    }
+
+    public function testTransformVariantWithMissingSku(): void
+    {
+        $variant = $this->getMinimalVariantData();
+        unset($variant['sku']);
+
+        $result = $this->adapter->transformVariant($variant, 'en-US');
+
+        $this->assertSame('', $result->sku);
+        $this->assertSame('', $result->jsonSerialize()['sku']);
+    }
+
     public function testTransformProductWithMissingRequiredFields(): void
     {
         $prestaShopData = [
@@ -1143,6 +1200,32 @@ private function getMinimalValidProduct(): array
         ];
     }
 
+    /**
+     * Helper method to get minimal variant data.
+     *
+     * @return array<string, mixed>
+     */
+    private function getMinimalVariantData(): array
+    {
+        return [
+            'remoteId' => '12345',
+            'sku' => 'VARIANT-SKU',
+            'price' => 29.99,
+            'basePrice' => 39.99,
+            'priceTaxExcluded' => 24.79,
+            'basePriceTaxExcluded' => 33.05,
+            'productUrl' => [
+                'localizedValues' => [
+                    'en-US' => 'http://example.com/variant',
+                ],
+            ],
+            'imageUrl' => [
+                'small' => 'http://example.com/small.jpg',
+                'medium' => 'http://example.com/medium.jpg',
+            ],
+        ];
+    }
+
     /**
      * Helper method to get minimal product data.
      *

tests/V2/ValueObjects/BulkOperations/ProductBuilderTest.php

@@ -194,18 +194,16 @@ public function testThrowsExceptionForMissingId(): void
             ->build();
     }
 
-    public function testThrowsExceptionForMissingSku(): void
+    public function testBuildWithoutSkuDefaultsToEmptyString(): void
     {
         $builder = new ProductBuilder();
-
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('Product SKU is required.');
-
-        $builder
+        $product = $builder
             ->id(self::PRODUCT_ID)
             ->pricing($this->createPricing())
             ->imageUrl($this->createImageUrl())
             ->build();
+
+        $this->assertSame('', $product->sku);
     }
 
     public function testThrowsExceptionForMissingPricing(): void