BRD-1053: carry Shopify variant image into variant imageUrl

[PauliusInvertus]

Why

Shopify variants were sent without imageUrl on purpose (686a7ac), so search results always showed the parent image even when a specific variant matched. PO decision (BRD-1225 comment 141084): match PrestaShop — show the matched variant's photo.

Change

• ShopifyAdapter::transformVariants sets imageUrl {small, medium} from variant.image.url when the variant has its own image; variants without one carry no imageUrl, so brad-search keeps the product image (empty-skip from BRD-1225).
• Test replaced: testVariantWithOwnImageCarriesImageUrl.

Needs bradsearch-shopify-app1 to fetch image { url } on variants (companion PR) and a re-sync.

Jira: BRD-1053

🤖 Generated with Claude Code

Independent validation

• Requirements: OK (variant with image → imageUrl {small,medium}; without → key absent; product image untouched)
• Adversarial: no defects; all four image shapes (missing/null/array/string) safe under failOnWarning
• Assumptions: ProductVariant.image is deprecated in Admin API 2026-04 → switched to media(first: 1) { nodes { ... on MediaImage { image { url } } } } (https://shopify.dev/docs/api/admin-graphql/2026-04/objects/ProductVariant)

Note: this deliberately reverses the earlier "keep the merchant's curated featuredImage" decision (686a7ac) per PO on BRD-1225.

[PauliusInvertus]

@claude review

[claude]

Claude finished @PauliusInvertus's task in 3m 0s —— View job

---

Review

• Gather context (diff, changed files, CLAUDE.md conventions)
• Review ShopifyAdapter.php changes
• Review test changes
• Post review feedback

Summary: Small, well-scoped change. Logic and tests look correct to me — nothing blocking.

What I checked

• src/Adapters/ShopifyAdapter.php:740-743 — sets imageUrl from variant['image']['url'] only when it's a non-empty string, otherwise the key is omitted entirely (not set to null/''). That matches the "empty-skip" contract described in the PR body and is exercised by the test (assertArrayNotHasKey('imageUrl', $variants[1]) for the null-image variant).
• Shape consistency: ['small' => $url, 'medium' => $url] matches the ImageUrl value object's required fields (src/V2/ValueObjects/Product/ImageUrl.php:26-33, both small/medium required) and mirrors how PrestaShopAdapterV2 populates variant imageUrl — good alignment with the "match PrestaShop" goal stated in the PR.
• Null-safety: $variant['image']['url'] ?? null is safe whether image is absent, null, or an array without url — no undefined-index warnings, which matters since phpunit.xml has failOnWarning.
• The stale doc comment explaining the old "never surface variant image" rationale was correctly removed rather than left dangling.
• ShopifyAdapter emits plain arrays (not V2 ValueObjects), so this isn't part of the OpenAPI golden-fixture contract in the root CLAUDE.md — no fixture update needed here, and none was made. Correct.
• Test replacement (testVariantWithOwnImageCarriesImageUrl) covers both the with-image and without-image (image: null) variant cases in one test — reasonable coverage for the change.

Minor, non-blocking notes

• .phpunit.cache/test-results is included in the diff. It's already a tracked file from before this PR (not introduced here), so this is just pre-existing churn, not something this PR needs to fix.
• The test's mocked variant image includes width/height fields that go unused by the new code (only url is read) — harmless, just noting it's consistent with the companion app PR only needing to fetch image { url }.

Note on verification: I wasn't able to execute vendor/bin/phpunit, phpstan, or phpcs in this environment — Bash tool calls for those commands required approval that isn't available here. I reviewed the diff and surrounding code manually instead; if you'd like me to actually run the quality-gate triple, the --allowedTools for this workflow would need to permit vendor/bin/* execution.