Release v1.2.8

[MarijusDilys]

Self-Checks

• I have performed a self-review of my code.
• I have updated/added necessary technical documentation in the README file.

JIRA task link

Summary

QA Checklist Labels

• Bug fix?
• New feature?
• Improvement?
• Technical debt?
• Reusable?
• Covered by tests?

QA Checklist

Additional Context

Frontend Changes

[gemini-code-assist]

Summary of Changes

Hello @MarijusDilys, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces version 1.2.8 of the module, focusing on enhancing the checkout experience and administrative control. It provides the ability to consolidate various credit/debit card payment options into a single 'Cards' choice for a cleaner user interface, and adds a new setting to manage the sending of order confirmation emails by the module after payment. These changes aim to improve both user experience and merchant flexibility.

Highlights

• New Feature: Card Grouping: Implemented a new feature that allows multiple debit/credit card brands (e.g., Visa, Mastercard, Amex) to be grouped under a single 'Cards' payment option in the checkout, configurable via a new setting in the admin panel. This aims to simplify the payment method selection for customers.
• New Feature: Order Confirmation Email Control: Added a new setting that provides merchants with control over whether the module sends an order confirmation email upon successful payment completion, offering more flexibility in email communication workflows.
• Configuration & Upgrade: Introduced new configuration constants for the aforementioned features and included an upgrade script (install-1.2.8.php) to ensure these new settings are properly initialized to a disabled state (0) upon module upgrade.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new version v1.2.8, which includes features for grouping card payments and configuring order confirmation emails. The changes are spread across configuration, services, controllers, and templates, and include a database upgrade script for the new settings.

Overall, the changes are well-structured. However, I've identified a critical issue that could lead to a fatal error, a high-severity logic flaw that might affect the user experience by showing a non-functional payment method, and a few medium-severity issues related to code style and user experience. Addressing these points will improve the quality and robustness of this release.