Sl 327 safer pay orders not sending email notifications when order status changes to shipped fixed

[TLabutis]

Self-Checks

• I have performed a self-review of my code.
• I have updated/added necessary technical documentation in the README file.

JIRA task link

Summary

QA Checklist Labels

• Bug fix?
• New feature?
• Improvement?
• Technical debt?
• Reusable?
• Covered by tests?

QA Checklist

Additional Context

Frontend Changes

[gemini-code-assist]

Summary of Changes

Hello @TLabutis, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug preventing email notifications for SaferPay orders when their status changes, specifically for 'shipped' orders. It also introduces a new feature that allows e-commerce administrators to group various debit and credit card payment options under a single, consolidated 'Cards' method in the checkout process, enhancing user experience and streamlining payment selection.

Highlights

• Email Notification Fix: Resolved an issue where SaferPay orders failed to send email notifications upon status changes, ensuring customers receive timely updates, particularly for 'shipped' orders.
• Configurable Order Confirmation Emails: Introduced a new setting to give administrators granular control over whether order confirmation emails are sent upon payment completion for SaferPay transactions.
• Grouped Card Payments: Implemented a new feature allowing multiple debit/credit card brands to be presented as a single 'Cards' payment option in the checkout, improving payment method clarity for customers.
• Customizable Card Grouping Logo: Added an option to display a dedicated logo for the newly grouped 'Cards' payment method, providing visual consistency.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes a critical bug that prevented email notifications, such as for shipped orders, from being sent for Saferpay transactions. The logic in hookActionEmailSendBefore has been corrected to only block specific, configured email templates, while allowing all others to be sent. Additionally, a new feature has been introduced to group various card payment methods under a single 'Cards' option in the checkout, which can be configured in the admin panel. My review includes a suggestion to update the changelog to reflect the bug fix and a minor code style improvement in the new upgrade script.

[gemini-code-assist]

The changelog for version 1.2.8 is missing the main bug fix introduced in this pull request. According to the PR title, a critical bug regarding email notifications for shipped orders was fixed. It's important to document this fix for users and future developers.

I suggest updating the changelog to include this information.

Suggested change

	## [1.2.8]
	- Added new setting to group debit/credit cards as 'Cards' in checkout
	- Added new setting to send order confirmation mail on payment completion
	## [1.2.8]
	- Fixed an issue where email notifications for order status changes (e.g., 'shipped') were not being sent for Saferpay orders.
	- Added new setting to group debit/credit cards as 'Cards' in checkout
	- Added new setting to send order confirmation mail on payment completion

[gemini-code-assist]

This function contains an unnecessary line with whitespace. For better code style and readability, it should be removed and a proper blank line can be added before the return statement.

function upgrade_module_1_2_8()
{
    Configuration::updateValue(SaferPayConfig::SAFERPAY_GROUP_CARDS, 0);
    Configuration::updateValue(SaferPayConfig::SAFERPAY_SEND_ORDER_CONF_MAIL, 0);

    return true;
}