Revert "SL-329 optimize db"

[MarijusDilys]

Reverts #297

[gemini-code-assist]

Summary of Changes

Hello @MarijusDilys, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request serves as a complete revert of a prior database optimization effort. It systematically undoes modifications to database schema by removing previously added indexes during installation and upgrades. Furthermore, it restores the original method of handling integer identifiers in database queries within key repository classes, ensuring consistency with the state before the optimization attempt. The removal of the TASKS.md file also indicates a rollback of the associated planning or documentation for future improvements.

Highlights

• Revert of Database Optimizations: This pull request fully reverts the changes introduced in a previous PR (SL-329 optimize db #297) that aimed to optimize database interactions.
• Database Index Removal: Newly added database indexes are removed from the module's installation scripts and upgrade routines for tables such as saferpay_order, saferpay_assert, saferpay_card_alias, and saferpay_order_refund.
• Query Parameter Handling Reverted: Changes to how integer IDs are handled in database queries within SaferPayCardAliasRepository and SaferPayOrderRepository classes are undone, specifically removing string quoting around integer values in WHERE clauses.
• Removal of TASKS.md: The TASKS.md file, which contained a detailed list of module improvement tasks across various categories, has been removed.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request reverts a previous set of database optimizations. While this might be necessary to fix an issue introduced by the original changes, it's important to be aware of the consequences. This revert removes numerous database indexes from several tables, which will likely lead to significant performance degradation on database queries. Additionally, several repository methods have been changed to wrap integer values in quotes within SQL WHERE clauses. This is an anti-pattern that can prevent the database from using indexes, further harming performance. These changes should be carefully considered, and a plan to re-introduce proper database optimizations without the original side-effects should be prioritized.